From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CC57396D09 for ; Fri, 2 Oct 2026 20:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790973457; cv=none; b=TxeLPbIzAfoppN4LOY0TjgNoYe+FiTTxNgbYgJcflDGLrMptv6Ej+R/g9SN6HbEUWtM4C8YJKtxVGvrLrkCHv+MPZsuWootp6ddeu/ozjUIMWbLxTa/q2g87V/2fFN2Kn+i//uHMr0HKW179FckH7/FbZ+/YF0pb3N5RfyE6wSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790973457; c=relaxed/simple; bh=piBmNj5rI0lM/5KZNljbCn4piFmadLH1W4LnMRaT9oQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M+1SO1KJeovZ36TGs8PschN6+4tLj+vJXUZHrpUwWizqHUoie1Cr1XKiclrD6xq7XMmiDbAbHyCTSYHj9yuzdr/wDmzKR0fTiwoKNCY47yLCd8lbssYKXwOlhhi3H3Or4bfur7pGpwEdgEI6XV6Vrakmd30aveip+j3e9XfIwCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=JJvJTmfw; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="JJvJTmfw" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccafb751so206022a91.2 for ; Fri, 02 Oct 2026 13:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1790973453; x=1791578253; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZWyIbgtdG1xO//+PcoG5gcw5NnsZw/9pPTdZ/soZ+kY=; b=JJvJTmfwCOBoROLaOoVmvtNI4bL5OqXBzjEP/wTV7iqquU2SdUYy6Fe3kDvViOnUk0 NpdBoT3f9FsPp56h7YhOyPqUW7U65jgtjvL5h0AKdlXrAn66gFGML8Lu9IkEUYneMK1+ LZFv4wuY1PZNdOhM3Ni8ohiGWjJQP3Oe5F803+2LWyX1MYzJH+5Xy0cNx2fF33aOY2zk qKJTM75W0TgLw2xAjbWgpYjwQyjIfiU/jIsH9QlBg8MF/vcQkZxbRnw3TBXgUQQIsp69 a77wY9gmaJdU/Lboed42W6GFYxfYHv3fSzFDBIR/N93YPltVAn8TXnK5s3tbwRMLUK1v 3/LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790973453; x=1791578253; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ZWyIbgtdG1xO//+PcoG5gcw5NnsZw/9pPTdZ/soZ+kY=; b=WJ2FMvwLtc1pGorNwREgOSFsnT+8n/Qmljt7f+a3U3/N5jR8jHRSkZyhVeL5A3Z7lF vZsSuUwhKA3H+eqzvIMkoKjVmNjJ4+IlCvqW5dxSxztxy9YwtE00YRFxja2AP4YWt6Zk Zk60vVOG6uhdjX9cL29HK4Nht9b9rSGrNidVWbXbIzNQn2+p20oZlJ/7HkZKDTU7Lgdm 0M8uDCXbNeOyz60mpxJ5ieAAtUqltkXoQ/VTHnvZD0osdP7PAiAb0PfX9AgbwWQfJ4MB Wn/HEF08zwS1EjtMhVN9ltND1sz1HWzMq3bKls2T5ArAfg0QhzydldPJoCLOyq4BVoT/ N0rQ== X-Forwarded-Encrypted: i=1; AKwUvBwjZ77ktR6HF/ACOJ6U1LD3l47vv86Kzfbj2mfFYTRBWn3xXK3K03Kz+nZiwYaTjTSesmUsB5k=@vger.kernel.org X-Gm-Message-State: AFq9FYKm38/opLprEDyXNGRs5GFHkRWfFBGHJbuULJSxuHsklYPkCxk2 /IgAgPJ0biWtihtrvOXCxzKSP0CG0TMzkMhXrQd2edzqmwSbamS8BzznXkIz+ah8dlc= X-Gm-Gg: AYBFou2H/1LJaCn69X3PlupFTNwIEC3d1bnza3P2brSDeanUKQthBTHL3ha6Sj7b9uW R14ECZ1kX8fQl0irq84U6qWHoQ47rM9a2n0MmQPOTLlloclbHvmCXve0cYv3p66p9bPw+Vtrj0f VgBgktob9YVTsVOM0ShkgvysQP1/9yrSeKnQovf6ql3ZdF1fLjs3+u2S7zvS2YrjsEI0oumlo6D +VJEv3n4SmrrqwQftWFZSsBt+o19HQeoUOVXGwTR6m2GI2KbonvxhXTTBeK1+ALdR7mjhkojaWe y6lwLCPMfMpgte6MTIUdxgrCpBs7nNE1QOE/zwLf5uah/9OBmjNtS3eTW386LQWSaIgCJtQfENE HsxmLimtez/ct3NZXEsOqFnkfJNhjbVzLzGmA4DkLmv4/JTePJMBbAKxcEs9PrHj8ibzG/UUhnR HiAWjPDreug9NMg9yjB1kpsCwwRhLmxAezN6eUypNdkZmcl2KujiKxTcalIg1ZLl81fbve9Ti9q 4ZOAEmpCS4t X-Received: by 2002:a17:90b:1346:b0:3a0:ace4:d2b4 with SMTP id 98e67ed59e1d1-3a6ceaf84a3mr1664206a91.23.1790973453013; Fri, 02 Oct 2026 13:37:33 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:43::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a78d183206sm51091a91.0.2026.10.02.13.37.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 13:37:32 -0700 (PDT) Date: Fri, 2 Oct 2026 13:37:31 -0700 From: Joe Damato To: Andy Shevchenko Cc: Andy Shevchenko , Xuan Zhuo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Gu , Philo Lu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next v2 3/5] eea: Refactor error handling in eea_adminq_config_host_info() Message-ID: Mail-Followup-To: Joe Damato , Andy Shevchenko , Andy Shevchenko , Xuan Zhuo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Gu , Philo Lu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20261002100035.863275-1-andriy.shevchenko@linux.intel.com> <20261002100035.863275-4-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261002100035.863275-4-andriy.shevchenko@linux.intel.com> On Fri, Oct 02, 2026 at 11:59:21AM +0200, Andy Shevchenko wrote: > Use traditional pattern to check for error first in > eea_adminq_config_host_info(). > > Signed-off-by: Andy Shevchenko > --- > drivers/net/ethernet/alibaba/eea/eea_adminq.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Joe Damato