From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netdev-bot+sinfo@kernel.org
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, horms@kernel.org, fw@strlen.de, ja@ssi.bg
Subject: Re: [PATCH net-next 01/11] netfilter: synproxy: fix reset of ct seqadj when reopening a connection
Date: Sun, 4 Oct 2026 21:26:35 +0200 [thread overview]
Message-ID: <asKoa2wFW5QneXEA@chamomile> (raw)
In-Reply-To: <armg511ZWKl5ZqhZ@chamomile>
Hi,
Just a gentle bump to this net-next PR containing Netfilter updates.
Let me know if there is anything that needs to be addressed.
Thanks.
On Mon, Sep 28, 2026 at 01:04:07AM +0200, Pablo Neira Ayuso wrote:
> Hi,
>
> On Sun, Sep 27, 2026 at 10:40:44PM +0000, netdev-bot+sinfo@kernel.org wrote:
> > Hi!
> >
> > This is an automated message. This series looks like a fix, but its
> > commit messages seem to be missing some information:
> >
> > - How the issue was discovered, e.g. hit in production, hit during
> > development, syzbot report, manual code inspection, LLM or static
> > analysis tool scan.
> >
> > - Whether the issue was actually triggered, or is only theoretical
> > (e.g. found by code inspection). If it was triggered please include
> > the symptoms, like the stack trace or error messages.
> >
> > Please do not repost the series just to address the above. Instead,
> > reply to this email with the missing information, so that reviewers
> > can take it into account. If the series needs another revision for
> > other reasons, please include the information in the commit messages
> > then.
> >
> > The evaluation is done by an LLM so it may be wrong, if you think
> > that is the case please reply and explain.
>
> This are correctness fixes (no crashes to my knowledged, hence I
> decided to target net-next) as the cover letter specifies:
>
> Patch #1 TCP sequence tracking issue was reported by sashiko as the
> cover letter says.
>
> Patch #2 Just documentation update to fix incorrect information
> about the maximum number of expectations.
>
> Patch #3 Just a cleanup patch to remove a break;
>
> Patch #4 Just a cleanup, typos in comments.
>
> Patch #5 and #6 are the result of a human triggered review of the
> conntrack error stats by Phil Sutter, I think.
>
> Patch #7 is a preparation patch for #8.
>
> Patch #8 removes a unnecessary workqueue flush, submitter does not
> specify if it is visible in production, I suspect with
> a very large number of netns it must be. Author does not
> claim LLM assistance.
>
> Patch #9 is a fix triggered by sashiko report IIRC, I deemed it too
> large for net so I am routing this rework-fix to net-next.
>
> Patch #10 is a feature fix, IPv6 filtering does not work.
> I suspect it was found when trying to use this (broken)
> feature by the submitter.
>
> Patch #11 Ilya Maximets reports the CTA_ZONE filtering feature is
> not easy to infer from userspace, I don't think LLM
> triggered this, it looks more like an improvement to help
> userspace tools discover this feature.
>
> This is human written reply, my cover letter has been generated by me
> too to provide more context on these patches.
>
> Thanks!
>
next prev parent reply other threads:[~2026-10-04 19:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 22:34 [PATCH net-next 00/11] Netfilter updates for net-next Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 01/11] netfilter: synproxy: fix reset of ct seqadj when reopening a connection Pablo Neira Ayuso
2026-09-27 22:40 ` netdev-bot+sinfo
2026-09-27 23:04 ` Pablo Neira Ayuso
2026-10-04 19:26 ` Pablo Neira Ayuso [this message]
2026-10-05 13:04 ` Ilya Maximets
2026-10-05 20:53 ` Pablo Neira Ayuso
2026-09-29 2:40 ` patchwork-bot+netdevbpf
2026-09-27 22:34 ` [PATCH net-next 02/11] netfilter: conntrack: fix nf_conntrack_expect_max default value in documentation Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 03/11] netfilter: osf: remove unreachable break in nf_osf_ttl() Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 04/11] netfilter: fix several typos in comments Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 05/11] netfilter: conntrack: Untangle insert_failed counter from others Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 06/11] netfilter: conntrack: Untangle drop and invalid counters Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 07/11] net/sched: act_ct: set net pointer before publishing flowtable Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 08/11] netfilter: flowtable: check namespace before iterating flows Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 09/11] netfilter: nfnetlink: Fix for interrupted hook dumps Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 10/11] netfilter: ctnetlink: fix inverted IPv6 address match in dump filter Pablo Neira Ayuso
2026-09-27 22:34 ` [PATCH net-next 11/11] netfilter: conntrack: make filtering by zone discoverable Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asKoa2wFW5QneXEA@chamomile \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox