From: Joe Damato <joe@dama.to>
To: Eric Dumazet <edumazet@kernel.org>
Cc: Stefan Fleischmann <sfle@kth.se>,
netdev@vger.kernel.org, stable@vger.kernel.org,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
regressions@lists.linux.dev
Subject: Re: [REGRESSION] Commit 447cbe95ebb9 causes IOMMU DMA faults on macvlan/vlan with bnxt_en
Date: Mon, 5 Oct 2026 10:38:13 -0700 [thread overview]
Message-ID: <asPghf8DPk5pOczz@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <f0c52ecb-b85d-4a53-8329-a8d2fd5d72b8@kernel.org>
On Sun, Oct 04, 2026 at 01:46:08PM +0200, Eric Dumazet wrote:
>
>
> On 10/4/26 12:26, Stefan Fleischmann wrote:
> > Hi,
> >
> > I have bisected a regression introduced in kernel 6.18.51 (and 7.2.3).
> > The issue is still present in 6.18.55 and 7.2.9. Verified by reverting
> > 1517d1996b52 (the equivalent of 447cbe95ebb9 in the 6.18 branch) on top
> > of 6.18.51 and 6.18.55.
> >
> > The hardware is a Dell R640 server with Intel Xeon Silver 4210 and
> > Broadcom BCM57412 NetXtreme-E NIC.
> >
> > The network interface is configured as an untagged interface and has a
> > couple of tagged VLAN interfaces configured on top. All of these are
> > used by LXC containers with Macvlan.
> >
> > The interface comes up fine after boot, but after some time (anywhere
> > between 2 to 40 minutes) I see a DMA error in the kernel log (attached),
> > and the driver ends up tearing down the interface. It can be brought up
> > again after that, but it will hit a DMA error again after a while and
> > the interface goes down again.
> >
> > I'm happy to provide more debug info if needed, or test patches.
>
> Hi Stefan,
>
> Thanks for the bisect and detailed report.
>
> Notice that 0xfc499000 is on an exact 4KB page boundary. This points to a
> DMA read overrun where the Broadcom DMA engine reads past the end of a
> buffer mapped in page 0xfc498xxx into the adjacent unmapped page 0xfc499000.
>
> Have you tried a recent net kernel ?
>
> Could you please test whether disabling TSO or hardware VLAN offload
> prevents the crash? (maybe adding one option at a time)
>
> # ethtool -K eno1np0 tso off
>
> # ethtool -K eno1np0 tx-vlan-offload off
>
> Adding Joe to this thread, because some parts in
> tso_dma_map_init() or tso_start() might have bugs.
Thanks for adding me and debugging this.
We've been hitting a similar read fault for a very long time I've had trouble
tracking down (it's been reproducing since at least kernel 6.9, long before my
SW USO changes).
In the case I am tracking, it seems to reproduce (fairly rarely) and seems to
be caused by a tcpv6 TSO packet with a read fault in the last page of a 32k
frag. I have yet to find a reproducer for my issue, though :(
I'll try this patch, but IIUC padding only applies to frames under 52 bytes,
so I'm not sure if it's the same bug I have been searching for.
prev parent reply other threads:[~2026-10-05 17:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 10:26 [REGRESSION] Commit 447cbe95ebb9 causes IOMMU DMA faults on macvlan/vlan with bnxt_en Stefan Fleischmann
2026-10-04 11:46 ` Eric Dumazet
2026-10-04 14:35 ` Stefan Fleischmann
2026-10-04 17:29 ` Stefan Fleischmann
2026-10-04 20:52 ` Eric Dumazet
2026-10-04 21:11 ` Eric Dumazet
2026-10-04 22:29 ` Michael Chan
2026-10-05 1:59 ` Eric Dumazet
2026-10-05 9:44 ` Fabian Grünbichler
2026-10-05 10:14 ` Eric Dumazet
2026-10-05 12:54 ` Stefan Fleischmann
2026-10-06 21:35 ` Sasha Levin
2026-10-07 10:33 ` Thorsten Leemhuis
2026-10-07 11:08 ` Eric Dumazet
2026-10-05 17:38 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asPghf8DPk5pOczz@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=edumazet@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=regressions@lists.linux.dev \
--cc=sfle@kth.se \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox