From: Daniel Thompson <daniel@riscstar.com>
To: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
Cc: netdev-bot+sinfo@kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Vladimir Oltean <olteanv@gmail.com>, Furong Xu <0x1207@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH net-next v5 0/3] net: stmmac: Introduce hw queue priority offload
Date: Tue, 6 Oct 2026 17:18:14 +0100 [thread overview]
Message-ID: <asUfRhPF-J74TCgG@aspen.lan> (raw)
In-Reply-To: <asTnyCWBTMC-B191@lore-desk>
On Tue, Oct 06, 2026 at 02:21:28PM +0200, Lorenzo Bianconi wrote:
> > Hi!
> >
> > This is an automated message. This series looks like a fix, but its
> > commit messages seem to be missing some information:
> >
> > - Whether the issue was actually triggered, or is only theoretical
> > (e.g. found by code inspection). If it was triggered please include
> > the symptoms, like the stack trace or error messages.
>
> This is a theoretical issue found during code inspection.
I haven't triggered anything specific for the real_num_tx_queues changes
but the overall with/without mqprio offload changes can (and have) been
reproduced with netperf:
netperf -H 192.168.10.2 -s 1 -l 12 -y 7 -t UDP_STREAM -- -m 1472 & \
netperf -H 192.168.10.2 -s 2 -l 10 -y 5 -t UDP_STREAM -- -m 1472 & \
wait
With the patchset applied (and the traffic class 7 mapped to a higher
priority queue and TC 5) then the split of bandwidth massively favours
TC 7 (with a 2.5G link. TC 7 measure ~2G versus TC 5 at ~2M).
Without the patchset both streams get ~1G.
I guess FWIW the whole series is:
Tested-by: Daniel Thompson <daniel@riscstar.com>
Daniel.
prev parent reply other threads:[~2026-10-06 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 10:46 [PATCH net-next v5 0/3] net: stmmac: Introduce hw queue priority offload Lorenzo Bianconi
2026-10-06 10:46 ` [PATCH net-next v5 1/3] net: stmmac: set real_num_tx_queues to max(offset + count) Lorenzo Bianconi
2026-10-06 10:46 ` [PATCH net-next v5 2/3] net: stmmac: align real_num_tx_queues to mqprio configuration Lorenzo Bianconi
2026-10-06 10:46 ` [PATCH net-next v5 3/3] net: stmmac: add tc mqprio hw queue priority offload Lorenzo Bianconi
2026-10-08 15:31 ` Daniel Thompson
2026-10-06 10:49 ` [PATCH net-next v5 0/3] net: stmmac: Introduce " netdev-bot+sinfo
2026-10-06 12:21 ` Lorenzo Bianconi
2026-10-06 16:18 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asUfRhPF-J74TCgG@aspen.lan \
--to=daniel@riscstar.com \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox