Netdev List
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Stanislav Fomichev <sdf.kernel@gmail.com>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
	<magnus.karlsson@intel.com>, <stfomichev@gmail.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>,
	<tushar.vyavahare@intel.com>, <kerneljasonxing@gmail.com>,
	<bjorn@kernel.org>
Subject: Re: [PATCH net-next 00/13] selftests: net: migrate AF_XDP test suite over to net
Date: Wed, 7 Oct 2026 14:22:06 +0200	[thread overview]
Message-ID: <asY5bpkHoqiX7rxk@boxer> (raw)
In-Reply-To: <asVwEyCK0NR4AwE9@devvm7509.cco0.facebook.com>

On Tue, Oct 06, 2026 at 03:04:08PM -0700, Stanislav Fomichev wrote:
> On 10/06, Maciej Fijalkowski wrote:
> > On Mon, Oct 05, 2026 at 11:06:52AM -0700, Stanislav Fomichev wrote:
> > > On 10/01, Maciej Fijalkowski wrote:

[...]

> > > > 
> > > > 
> > > > Known issues:
> > > > - Every case pays for process start-up, XDP attach and detach and, on
> > > >   hardware, its remote commands. We used to configure resources once
> > > >   and then execute the whole test suite; it doesn't seem to be
> > > >   CI-friendly and it is preferred to have each case's resource
> > > >   management separated; that on the other hand increases the
> > > >   execution time of the whole test suite.
> > > 
> > > [..]
> > > 
> > > > - The XDP programs redirect every packet, so the link under test must
> > > >   carry no other traffic. SSH and the control channel go to the
> > > >   REMOTE_ARGS host, which has to be reached over another link.
> > > 
> > > Will this work on NIPA?
> > 
> > Yeah good that you're bringing this up, I see NIPA has a e810 setup within
> > same machine which is not what i tested on my side. This means the
> > assumption/requirement of having isolated link under test has to be lifted
> > as e810 cards on NIPA will carry management traffic via same link. I'll
> > add XDP prog logic as you point out, thanks.
> > 
> > I also hit the ice bug after connecting interfaces within single machine
> > which was hiding from me throughout whole local testing, during RSS update
> > where we only want to touch indirection table, symmetric-xor hashing was
> > being turned on which caused later rss operations to fail; I'll post a fix
> > to iwl-net and include some heads-up to v2.
> > 
> > > 
> > > I took a quick pass, nothing pops us for me. The only thing I'm not sure
> > > is the bpftool dependency (whether we need to build it or there is
> > > something on the system).
> > 
> > We need it due to skeleton usage and other change was also utilizing it so
> > I thought it would be acceptable.
> 
> No, no, I'm not questioning the need, just not sure whether we need to build
> it in the selftest makefiles (like bpf selftests do) or it's ok to use
> the system one (if there is one).

We could build it within makefiles as a bootstrap. How about that? I am
not aware how much of an effort would be to provide system installs of
bpftool on CI runners, so maybe this smaller build would be acceptable?

  reply	other threads:[~2026-10-07 12:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 20:21 [PATCH net-next 00/13] selftests: net: migrate AF_XDP test suite over to net Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 01/13] selftests: xsk: factor endpoint work out of pthread wrappers Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 02/13] selftests: xsk: drop the single-interface loopback mode Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 03/13] selftests/bpf: drop the test_progs AF_XDP wrapper Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 04/13] selftests: net: add a generic rule for BPF skeletons Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 05/13] selftests: xsk: move the AF_XDP test suite to selftests/net Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 06/13] selftests: xsk: collect interface capabilities in struct xsk_caps Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 07/13] selftests: xsk: split xskxceiver main() into setup, run and cleanup Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 08/13] selftests: xsk: run one test case per xskxceiver invocation Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 09/13] selftests: xsk: run the RX and TX endpoints in separate processes Maciej Fijalkowski
2026-10-02 18:07   ` Vyavahare, Tushar
2026-10-01 20:21 ` [PATCH net-next 10/13] selftests: xsk: add a hardware mode to xskxceiver Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 11/13] selftests: xsk: share test case definitions with hardware runner Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 12/13] selftests: drv-net: test AF_XDP zero-copy with an SKB peer Maciej Fijalkowski
2026-10-01 20:21 ` [PATCH net-next 13/13] selftests: xsk: document generic and hardware endpoint runs Maciej Fijalkowski
2026-10-05 18:06 ` [PATCH net-next 00/13] selftests: net: migrate AF_XDP test suite over to net Stanislav Fomichev
2026-10-06 17:42   ` Maciej Fijalkowski
2026-10-06 22:04     ` Stanislav Fomichev
2026-10-07 12:22       ` Maciej Fijalkowski [this message]
2026-10-07 17:26         ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asY5bpkHoqiX7rxk@boxer \
    --to=maciej.fijalkowski@intel.com \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf.kernel@gmail.com \
    --cc=stfomichev@gmail.com \
    --cc=tushar.vyavahare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox