From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Zihan Xi <zihanx@nebusec.ai>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
phil@nwl.cc, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org
Subject: Re: [PATCH nf v3 1/1] netfilter: x_tables: avoid holding mutex over faultable user copies
Date: Fri, 9 Oct 2026 02:14:52 +0200 [thread overview]
Message-ID: <asgx_COtYd1PifN2@chamomile> (raw)
In-Reply-To: <asgwR9LsGCEMolQX@strlen.de>
On Fri, Oct 09, 2026 at 02:07:35AM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > The ebtables GET paths use a separate ebt_mutex and are outside this
> > > IPv4/IPv6/ARP series.
> >
> > I keep spinning on this, and I am not sure this fix is the right thing
> > to do. There is no single caller of this pagefault_disable/enable() mm
> > subsystem function in the net folder.
>
> See:
>
> https://lore.kernel.org/all/CAL4Wiir+CBGE=hXxHEBkyk0Au9B6G3=AdHFd5botrC-FF5BM5w@mail.gmail.com/raw
>
> Quote:
> | We have many places where copy_{from,to}_user() runs while a mutex or
> | a socket lock is held, and some of these locks are global.
Indeed.
> So I would not spend too much time on this, especially not for the
> xtables get/setsockopt APIs.
OK, I'll drop this patch in patchwork then.
Thanks Florian.
next prev parent reply other threads:[~2026-10-09 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 11:58 [PATCH nf v3 0/1] netfilter: x_tables: avoid holding mutex over faultable user copies Zihan Xi
2026-09-20 11:58 ` [PATCH nf v3 1/1] " Zihan Xi
2026-10-08 23:54 ` Pablo Neira Ayuso
2026-10-09 0:07 ` Florian Westphal
2026-10-09 0:14 ` Pablo Neira Ayuso [this message]
2026-10-09 1:09 ` zihan xi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asgx_COtYd1PifN2@chamomile \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=zihanx@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox