From: Narcisa Vasile <narcisav.kernel@gmail.com>
To: Tianyi Gao <tianyi@cloudflare.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, shuah@kernel.org,
toke@toke.dk, lorenzo@kernel.org, hawk@kernel.org,
ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
sdf@fomichev.me, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: [PATCH net-next] selftests: net: veth: test own ndo-xmit after peer GRO toggle while down
Date: Sun, 11 Oct 2026 21:53:10 -0700 [thread overview]
Message-ID: <asxntk6HV+jmAlKe@gmail.com> (raw)
In-Reply-To: <20261010192914.83651-1-tianyi@cloudflare.com>
On Sat, Oct 10, 2026 at 08:29:14PM +0100, Tianyi Gao wrote:
> Test that a veth device advertises ndo-xmit when GRO is enabled on its
> peer while both are down and only the device is brought up.
>
> Commit 7a6102aa6df0 ("veth: Update XDP feature set when bringing up
> device") made veth_open() set the flag in this case, and selftests were
> requested in its review [1].
>
> The block now ends with GRO enabled while the peer is down, so the
> aggregation check that follows covers NAPI enabled by veth_open() again.
> Commit c017800af5c7 ("selftests: net: veth: test peer ndo-xmit after GRO
> toggle while down") had moved it to veth_set_features() [2].
>
> Link: https://lore.kernel.org/all/155aabf8b873bb8cdcafbd6139c42b08513e5fe6.camel@redhat.com/ [1]
> Link: https://lore.kernel.org/all/179165459278.434549.1711113374323842550@kernel.org/ [2]
> Signed-off-by: Tianyi Gao <tianyi@cloudflare.com>
> ---
Reviewed-by: Narcisa Vasile <narcisav.kernel@gmail.com>
prev parent reply other threads:[~2026-10-12 4:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 19:29 [PATCH net-next] selftests: net: veth: test own ndo-xmit after peer GRO toggle while down Tianyi Gao
2026-10-12 4:53 ` Narcisa Vasile [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asxntk6HV+jmAlKe@gmail.com \
--to=narcisav.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=tianyi@cloudflare.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox