From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Binbin Deng <18983559317@163.com>
Cc: <sgoutham@marvell.com>, <gakula@marvell.com>,
<sbhatta@marvell.com>, <bbhushan2@marvell.com>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] octeontx2: Fix use-after-free of qos node in delete path
Date: Fri, 16 Oct 2026 08:14:20 +0530 [thread overview]
Message-ID: <atGPhOA3oH_g1RTm@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20261014064204.291688-1-18983559317@163.com>
On 2026-10-14 at 12:12:04, Binbin Deng (18983559317@163.com) wrote:
> hash_del_rcu() only unlinks the node; a reader that already holds the
> bucket iterator still uses the node. The immediate kfree() has no
> grace period, so a concurrent transmit on a socket whose skb priority
> carries the deleted classid reads node->classid / node->qid from freed
> memory (use-after-free in the softirq transmit path).
>
> Fix this by calling synchronize_net() before the node is freed, as
> mlx5e does.
>
> Found during a static-analysis-assisted audit: candidate sites were
> surfaced by a Coccinelle rule, and the reader/writer paths were
> confirmed by LLM-assisted (GLM-5.3) code inspection. The issue was
> not observed at runtime; it is identified by code inspection only.
>
> Fixes: 5e6808b4c68d ("octeontx2-pf: Add support for HTB offload")
> Signed-off-by: Binbin Deng <18983559317@163.com>
Reviewed-by: Ratheesh Kannoth <rkannoth@marvell.com>
next prev parent reply other threads:[~2026-10-16 3:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:42 [PATCH v1] octeontx2: Fix use-after-free of qos node in delete path Binbin Deng
2026-10-14 6:45 ` netdev-bot+sinfo
2026-10-16 2:44 ` Ratheesh Kannoth [this message]
2026-10-20 19:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atGPhOA3oH_g1RTm@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=18983559317@163.com \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox