From: Kuniyuki Iwashima <kuniyu@google.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Eric Dumazet <edumazet@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jakub Kicinski <kuba@kernel.org>,
Levi Zim <rsworktech@outlook.com>,
Denis Yarapov <yarapov_d@mcst.ru>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
lvc-project@linuxtesting.org, Sashiko <shodan.ai@mcst.ru>
Subject: Re: [PATCH v2] tcp_bpf: propagate error code in tcp_bpf_sendmsg()
Date: Tue, 20 Oct 2026 04:44:25 +0000 [thread overview]
Message-ID: <atbxndUiT5qkAER3@google.com> (raw)
In-Reply-To: <20261019082214.102398-1-dmantipov@yandex.ru>
On Mon, 19 Oct 2026 11:22:14 +0300, Dmitry Antipov wrote:
> In tcp_bpf_sendmsg(), the value returned by sk_msg_memcopy_from_iter()
> is checked for error but not propagated to 'out_err' label, so error
> handling may not work as expected. Fix this by assigning error value
> to 'err', thus making sure that error won't be silently ignored.
>
> Reported-by: Sashiko <shodan.ai@mcst.ru>
> Fixes: 5153a75ef34b ("tcp_bpf: Fix copied value in tcp_bpf_sendmsg")
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
next prev parent reply other threads:[~2026-10-20 4:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 8:22 [PATCH v2] tcp_bpf: propagate error code in tcp_bpf_sendmsg() Dmitry Antipov
2026-10-19 8:28 ` netdev-bot+sinfo
2026-10-20 4:44 ` Kuniyuki Iwashima [this message]
2026-10-20 6:23 ` Jason Xing
2026-10-20 7:50 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atbxndUiT5qkAER3@google.com \
--to=kuniyu@google.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dmantipov@yandex.ru \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=rsworktech@outlook.com \
--cc=shodan.ai@mcst.ru \
--cc=yarapov_d@mcst.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox