From: Oleg Nesterov <oleg@redhat.com>
To: Allison Henderson <achender@kernel.org>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
pabeni@redhat.com, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, joel.granados@kernel.org
Subject: Re: [PATCH net 1/2] net/rds: do not fail init when CONFIG_SYSCTL=n
Date: Thu, 22 Oct 2026 14:33:11 +0200 [thread overview]
Message-ID: <atoCh3jw_1noK2Nr@redhat.com> (raw)
In-Reply-To: <20261021195837.142802-2-achender@kernel.org>
On 10/21, Allison Henderson wrote:
>
> Only treat the NULL return as a failure when sysctl support is actually
> compiled in. The exit paths need no change: unregister_net_sysctl_table()
> is an empty stub with CONFIG_SYSCTL=n and already tolerates a NULL header
> otherwise.
FWIW,
Acked-by: Oleg Nesterov <oleg@redhat.com>
I'll rebase my changes which move all the sysctl related code in net/rds
under ifdef(CONFIG_SYSCTL) on top and send the patch(es) for review.
Oleg.
next prev parent reply other threads:[~2026-10-22 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 19:58 [PATCH net 0/2] net/rds: fix init failures leaving built-in transports on a dead core Allison Henderson
2026-10-21 19:58 ` [PATCH net 1/2] net/rds: do not fail init when CONFIG_SYSCTL=n Allison Henderson
2026-10-22 7:22 ` Joel Granados
2026-10-22 12:33 ` Oleg Nesterov [this message]
2026-10-21 19:58 ` [PATCH net 2/2] net/rds: do not initialize transports after rds_init() failed Allison Henderson
2026-10-27 10:40 ` [PATCH net 0/2] net/rds: fix init failures leaving built-in transports on a dead core patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atoCh3jw_1noK2Nr@redhat.com \
--to=oleg@redhat.com \
--cc=achender@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joel.granados@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox