Netdev List
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Zhiling Zou <zhilinz@nebusec.ai>
Cc: <netdev@vger.kernel.org>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <edumazet@kernel.org>, <pabeni@redhat.com>,
	<horms@kernel.org>, <vega@nebusec.ai>
Subject: Re: [PATCH net 1/1] xfrm: ipcomp: account full fragment pages in truesize
Date: Fri, 6 Nov 2026 08:47:44 +0100	[thread overview]
Message-ID: <au2GILb3-9bN1i7G@gauss4> (raw)
In-Reply-To: <7f2686a7d3d393a0ef9eb7a2a2abe82caa7874b2.1792692779.git.zhilinz@nebusec.ai>

On Fri, Oct 23, 2026 at 02:32:17AM +0800, Zhiling Zou wrote:
> ipcomp_post_acomp() allocates order-0 pages for decompressed skb
> fragments, but on input charges truesize by the decompressed byte count.
> When the output ends partway through a page, the unused tail of its final
> page is not accounted to the receiving socket. Repeated IPComp packets
> can therefore retain more memory than the socket receive-memory limits
> charge.
> 
> Round the decompressed length up to page size when charging input skb
> truesize, matching the pages attached to the skb. Leave output accounting
> unchanged.
> 
> Fixes: 7d7e5a60c62e ("ipsec: ipcomp - Decompress into frags if necessary")
> Cc: stable@vger.kernel.org
> Reported-by: Vega <vega@nebusec.ai>
> Link: https://bugtracker.nebusec.ai/f/13830
> Assisted-by: LLM
> Signed-off-by: Zhiling Zou <zhilinz@nebusec.ai>

Applied to the ipsec tree, thanks a lot!

      reply	other threads:[~2026-11-06  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 18:32 [PATCH net 0/1] xfrm: ipcomp: account full fragment pages in truesize Zhiling Zou
2026-10-22 18:32 ` [PATCH net 1/1] " Zhiling Zou
2026-11-06  7:47   ` Steffen Klassert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=au2GILb3-9bN1i7G@gauss4 \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vega@nebusec.ai \
    --cc=zhilinz@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox