From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.197 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793078649; b=uzxlbn2LjnQpIiGnltJGcG/P8cVlj+fllBf3n3wIpyZc8SGz8bqc3vmCpHV/0bDgl2Pq kepYv7TvG2coQ1CchFyCmp5t30DWXONWa+h/elXoomPRmDGyd3gGwbQOb65jHvsygeKNg gjQw/jKPOVuoMKcO2f5sI8BCOdmEAyiZBE3DLs0PwNf2nwKw2pEkr7O+Gcu84Z0DJZ+Mz zIidxleYNp2EI5eMFUtyw1qh7J+EZrp+EtY2D0z0NFvY9mx6Gg5QWTzFEKwrS/56F1vuh kS7CaiAbuebVKQC6lzRS+irxY5oP87HHH+06T2Ae7Z0tIgNyQXCDEAfkSKQgL2v0kbg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793078649; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Received:Date:In-Reply-To:Mime-Version: References:Message-ID:Subject:From:To:Cc:Content-Type; bh=xeAWkq5Alu/mHalNdE2utUYKbLobeFhJLDwphT45bWA=; b=PWq7C9i6T8QbvIFUKSkoIz0elxPLFzqnGLT4wP6bIFZIPkRwYdUrHbAV2O1oPv4FEMm2 WxC3RMtMcs3LO2LW7lns7AecJAmQ1HNikR4lV7y5nwIk2spz6oCTAe4DVRJyvwvZ/U/PY ycS/Njwy6M0UE4AIX5fwDp9JWLD3qsbGgch2Xdwb0HJ2d/wHBRSMNvKbOTASSruHRwjAh vI388IVkYxEDiC0uoHIiHVV0kgh4DCFpyBT6mEHlnPFwCMaFDUfxBov268+Vfyneg/mC9 c4PnxaHCV0CFsOum2T+ODgzfl437hK1mDXov1v5QSd8i56OqoAQL4dGohiKQ1tDx8DQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=inGQFwot; arc=none smtp.remote-ip=209.85.210.197 Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CBB3606A31B for ; Tue, 27 Oct 2026 05:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9CBB3606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=inGQFwot Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8a086f5d91aso5537588b3a.1 for ; Mon, 26 Oct 2026 22:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793078648; x=1793683448; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xeAWkq5Alu/mHalNdE2utUYKbLobeFhJLDwphT45bWA=; b=inGQFwotqiHq2ADO4+3dmA7bfRluyd9vzegM7W2t7gIbd+cXyAJPjhLJjE6nPaVRuW nPqOWHqOfvuQu/uzHfR9J38/tTPz+G6Na3w2es2SD0WhaxYK6jngtdfN8pjnQc00DYh/ LEXrayfwniWJ3NGj+Lp08Z2QWux+8Oqf36J9mKkNslcvmklL7IHQ6Leyft5dB6EHKmSj jQuFL9Tk7pxI0cQXq1JZeDojrDUwgSMVu1P5RnMVc5JqnGWEkfOn8lvapeOVil8frBsv gf4GLTkDgGuW0fGxy/IDcDRgv3G0znwCXmNcRl4/YxfK9nwNEDnOwW2r6vjv3Q2eQGdQ BT9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793078648; x=1793683448; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xeAWkq5Alu/mHalNdE2utUYKbLobeFhJLDwphT45bWA=; b=OS1Fv20YOX7TzItn+x2KPMkRAXEk+fiQGSFrZOxTmVcxGiKgOGDP1KGr4QQzww2BiJ 2t7y4iCCzZexUe28U4+54oqzoS23XJNH6tWzQEwW4UIP/gUZrJqpzq7zURGKIuooEqx0 0OHZn9lBtHVPrFTC24ZpLPCcPAPluhVLqQucNxcwBNsOFwXY88vOIOAlKKTpwSrXd0Jg BPHooKy7/EIBr/xcvbk+3E/zZDeQKXrNga/nDxzg1HpsK7i8FmkgUHIPYyTmJkrFAAAY QRQGOzg3yRET/HCeSLiTT9ZpavTauF87HQmxFL8XtxWD6yNjouVCD868g9R/IlTa9tD8 VISg== X-Gm-Message-State: AFq9FYLzPfHCStS0UunSZV3A980I7UzzqyU8oPzG1uauwkpNqbSx3WNu 1QqVrHHu8AQUN0BTTrtpalUwpOpjruo1v0+YyxJoFkq5LSjs6xnkUUimv/JEal772Or3vJfTkdG 1zO/zyQ== X-Received: from pfh23.prod.google.com ([2002:a05:6a00:12d7:b0:8a0:7c0e:8263]) (user=kuniyu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:8016:b0:888:2b10:e26b with SMTP id d2e1a72fcca58-8a36715c0dfmr7327494b3a.18.1793078647730; Mon, 26 Oct 2026 22:24:07 -0700 (PDT) Date: Tue, 27 Oct 2026 05:24:07 +0000 In-Reply-To: <20261023091419.167088-4-jiayuan.chen@linux.dev> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261023091419.167088-1-jiayuan.chen@linux.dev> <20261023091419.167088-4-jiayuan.chen@linux.dev> Message-ID: Subject: Re: [PATCH net 3/5] ipv6: restrict mld_qrv to 255 From: Kuniyuki Iwashima To: Jiayuan Chen Cc: netdev@vger.kernel.org, stable@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Ido Schimmel , Neal Cardwell , Joel Granados , Chia-Yu Chang , Fernando Fernandez Mancera , Wyatt Feng , Yung Chih Su , Flavio Leitner , Hannes Frederic Sowa , "Paul E. McKenney" , Petr Mladek , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, 23 Oct 2026 17:13:29 +0800, Jiayuan Chen wrote: > net.ipv6.mld_qrv only has a lower bound, but ipv6_mc_reset() stores it > into the u8 inet6_dev::mc_qrv, and every MLD retransmit counter derived > from it (mca_crcount, sf_crcount, mc_ifc_count, mc_dad_count) is u8 as > well. Anything above 255 silently wraps: 256 becomes 0, so no state > change report is ever retransmitted, and the first MLDv2 Query received > on the interface then trips the WARN_ON() in mld_update_qrv(): > > WARN_ON(idev->mc_qrv == 0); > > A plain bridge with mcast_querier enabled on the link is enough: > > WARNING: net/ipv6/mcast.c:1327 at mld_query_work+0x1fd2/0x2cb0, CPU#3: kworker/3:1/2688 > Workqueue: mld mld_query_work > RIP: 0010:mld_query_work+0x1fd2/0x2cb0 > Call Trace: > > process_one_work+0x93a/0x1b20 > worker_thread+0x6d0/0x11d0 > kthread+0x358/0x470 > ret_from_fork+0x5b3/0x820 > ret_from_fork_asm+0x1a/0x30 > > > Cap the sysctl at U8_MAX, the largest value mc_qrv can actually hold. > > Fixes: 2f711939d2ea ("ipv6: add sysctl_mld_qrv to configure query robustness variable") > Cc: stable@vger.kernel.org > Signed-off-by: Jiayuan Chen > --- > net/ipv6/sysctl_net_ipv6.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/ipv6/sysctl_net_ipv6.c b/net/ipv6/sysctl_net_ipv6.c > index 1a0a36dcdabc..05a384680332 100644 > --- a/net/ipv6/sysctl_net_ipv6.c > +++ b/net/ipv6/sysctl_net_ipv6.c > @@ -29,6 +29,7 @@ static u32 rt6_multipath_hash_fields_all_mask = > FIB_MULTIPATH_HASH_FIELD_ALL_MASK; > static u32 ioam6_id_max = IOAM6_DEFAULT_ID; > static u64 ioam6_id_wide_max = IOAM6_DEFAULT_ID_WIDE; > +static int mld_qrv_max = U8_MAX; > > static int proc_rt6_multipath_hash_policy(const struct ctl_table *table, int write, > void *buffer, size_t *lenp, loff_t *ppos) > @@ -229,7 +230,8 @@ static struct ctl_table ipv6_rotable[] = { > .maxlen = sizeof(int), > .mode = 0644, > .proc_handler = proc_dointvec_minmax, inet6_dev.mc_qrv is u8, you can simply use proc_dou8vec_minmax() instead of adding extra2. > - .extra1 = SYSCTL_ONE > + .extra1 = SYSCTL_ONE, > + .extra2 = &mld_qrv_max, > }, > #ifdef CONFIG_NETLABEL > { > -- > 2.43.0 >