From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.229.7 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793734406; b=bOY2fLUG2ki4dVuodBXCzsfO4qDh+RMkekkFBUphuP1v+/3YvsGr0k1GXTPxbtMPq2th 0frW7LqODSBCbbysXoX10kzMbqraHfb7g44UsF4OfaYlaXAkivZrDjxU0jtLMqwLvMg6X 4N9HVi+XKTyQB7d0q5pdT2jE2GBQOy5xHwYwldVsqI9hcEik8JGhmreVmBJI5Zasew4tT Ch4E+CbR7oP26YceS+M7/QjR4xtOIHURHaGiy+oAtPKiQRDPTEQFrn0DqxxnlTHirl/gL 9Sjq0ed8Qhh8KcaMdR+57YD1/YRb5BnAV2nH1xMjHcaMDVenEqIpEbu8lu1vJS2biOQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793734406; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=WLkZnlYTPQB9u5XkBC13rSiJ7ZjBn3AlusJ3/Izfois=; b=Ret+Z5+lPFFafsQfPeZkljtZLyOcomm0+DJ0I5IN/B/WVbpxUGJYOyDq4o+CeQMCT95d G/W9hnjjoX3gy2J0BdH1MFxZ0M8zfTDBLjPULDuCWGaYrPaNaJsLAE+7Kpl15nDx9awUG bLvVs7GxwDQbIOJvZ8NwaMG10RaOmd7wtqPu/RWy2V6r4PlHNlXV5kFjqnkZbsU13IqqF zXFEptsAYYI2SV/ZZknNTCW+NQPQRaO7lGYq8MbyCCKV/MFB3wuVD5rJD3ClbPE5SGpMr ACQoYWoNCJKaziApasP07RipXojnCFODArEml0G6HqX6+qEzBz79t28wfVMIoCv58kA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=J61wv2ex; arc=none smtp.remote-ip=74.125.229.7 Received: from mail-dy2-f7.google.com (mail-dy2-f7.google.com [74.125.229.7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FFEB606D824 for ; Tue, 3 Nov 2026 19:33:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2FFEB606D824 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=J61wv2ex Received: by mail-dy2-f7.google.com with SMTP id 5a478bee46e88-36888ae05e7so1762519eec.0 for ; Tue, 03 Nov 2026 11:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793734405; x=1794339205; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WLkZnlYTPQB9u5XkBC13rSiJ7ZjBn3AlusJ3/Izfois=; b=J61wv2exN8htNK9lYuklAxCur6wcv0gV5hEC4LTnv0vsbzjE6WiHCt7vWZjwAitqGZ Z7QJGrGIyNMASgr4gdZuZj1Pu4FrPDgNq7pR64TF8oxW2MfIBxs8YSw804DfE+kcoqFa Z+DARbn0OIX1wVOExotXpAuNN6Bq0mUytJTfXlWwhCDJKVjg6shwf838sdNKtiGXZtNA kTL3VZ2irXkBCgWt7lgX730fCFRMNjbgrM8zlymS/OyKDhqfczbPlbUjQgX4NgsTN56b nnhnk4sJ4BnyPDMipav7BMCwKwX0BrEMBZAwBM+9E1xFpuf2BeG33U/EQifOTZyox99s xi1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793734405; x=1794339205; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WLkZnlYTPQB9u5XkBC13rSiJ7ZjBn3AlusJ3/Izfois=; b=DG62Qjl1IACI9yLHdg+gEedf22OjTDaF/KkF6yk7YQllSVKz8H0yajOGrTJtytgzJr b1Gtl5wOIXHML/wVPNDuNEDJU6rKxkBij1/MF8g3lNQQ7sGh6ecps1/uf1CygQnqh/A8 O/xZjsXEZ11GeyhDrmgiNBLJnDhixVN5zl8lAgZav+XPg8YGOQax9pOGyOQUL0EXkEXJ d01wuBhMhOpyPYpTYP7HRO3NkRX16uiClRxqPYmLs07sBRC+c+LCg74rRjCFlaBoJqeB Mcgceyc39bmehd18scLvkBJH6vv2w1mmaULJklIrBqDcmNXVD577SInbsdmBiQTZcQGR L44A== X-Forwarded-Encrypted: i=1; AKwUvBx0GITP9e4crpK/av/34QYlgtEOEP3/XCIMR1sambUUpMPdbPnbjsQA2qBJEMhSeR/4I+uJe4U=@vger.kernel.org X-Gm-Message-State: APuU4Z+SWxjAb8563w3LFhSNI2EB1bIBj6bMGmQmfqIj/nfZneFM31Em ICD4wFC/pTWU/MOGjOYXgDNkhSoZfjEZQlFyvvwBgmbE7+PRRgirPDr/ X-Gm-Gg: AYBFou3kpjj8R/ytxuOfi/hGs/n6Dt8pVgvhxjT8zXe//88qvGvzcHcSv1heeEPFTCy sNBqG/uQZJgY+JEc0jwk/PBTXkHILdUwpxdcMcC5TYTKGaLgIARGRJlvejKILj3dMs4yDQqcav7 zZQRn+H8UJfxDT0pT/ako7ZDyMLOXDso8iwlabGC9tM3FUOLNi0j9Msrua4mzTinSHJisPENwKK Y9f9yR88sQZXJOS3Q8xpIJs8HdfurrpsdJdjr0llJK+L64tM5wloDwndZ9acAy4fMIFZvEXiThP dmXeHbqeSZeGT5xXRD+Yv9rEGWXHVHPwZ2rPtgn+D/Ije9qP8uuh0U1wIEkqP51Lxdxz6lfP0R8 xPTYQSrdMnd0rs+lbUQGcNB3kxDCCktzwO6iPQzZTE0EuHKsnarrO8o5X2t8CcKGEYTVd4bs1x2 WVknFlR86YAJ/+M3QtIx1soEhECT7TXTNh5TiMzrvI806jABYjqDOAsG8Xj3MDRP/jX2VQGrHZD 1Lhg8sG2gCD+2tvEF9helSS/r4rkt1Od2Q7SqXWUdb/6dnJRgwyzprTgYASwiVPYhk67S1C+WWX gg5VVIIxFzYOU9JHHm8C2Q== X-Received: by 2002:a05:693c:4159:20b0:351:29c8:643 with SMTP id 5a478bee46e88-36a423a8b7fmr23017109eec.18.1793734404871; Tue, 03 Nov 2026 11:33:24 -0800 (PST) Received: from localhost ([2a03:2880:9ff:70::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36ca38a54ccsm285396eec.4.2026.11.03.11.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 11:33:24 -0800 (PST) Date: Tue, 3 Nov 2026 11:32:55 -0800 From: Stanislav Fomichev To: Breno Leitao Cc: David Ahern , Ido Schimmel , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , John Fastabend , Stanislav Fomichev , Shuah Khan , Eric Dumazet , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, david.laight.linux@gmail.com, kernel-team@meta.com Subject: Re: [PATCH net-next v4 7/7] selftests: net: getsockopt_iter: cover ip and ipv6 Message-ID: References: <20261103-sockopt_expand_out_v2-v4-0-2d36da923578@debian.org> <20261103-sockopt_expand_out_v2-v4-7-2d36da923578@debian.org> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261103-sockopt_expand_out_v2-v4-7-2d36da923578@debian.org> On 11/03, Breno Leitao wrote: > Add an ip and an ipv6 fixture, pinning the returned length and errno > across buffer sizes, the branches that answer empty, an unknown > optname and the options dispatched before the switch. The clamp tests > also compare the bytes copied back, not just the length. > > SOL_IP answers a sub-int buffer with one byte where SOL_IPV6 clamps the > int. IP_PKTOPTIONS and IPV6_2292PKTOPTIONS want a stream socket; > MRT_*/MRT6_* want a raw one. > > ipv6.pathmtu_negative_optlen pins the clamp of a negative optlen: taken > as 4, it is too short for IPV6_PATHMTU and fails with -EINVAL, where it > used to pass the length check and fail with -ENOTCONN. > > Only the two hop-by-hop tests set IPV6_HOPOPTS, which needs > CAP_NET_RAW, so the other ipv6 tests run unprivileged. > > The MRT_*/MRT6_* tests skip on a missing /proc/net/ip_mr_vif or > ip6_mr_vif, rather than on the ENOPROTOOPT the switch also answers for > an unrelated regression. A kernel with CONFIG_IP_MROUTE or > CONFIG_IPV6_MROUTE built in no longer hides that regression behind a > skip. > > The config fragment only had CONFIG_IPV6_MROUTE=y, so add > CONFIG_IP_MROUTE=y for the ip test, and CONFIG_IP_MULTICAST=y, which > IP_MROUTE depends on. > > MRT_VERSION and MRT6_VERSION are spelled out; linux/mroute.h does not > coexist with netinet/in.h here. > > Acked-by: Ido Schimmel > Signed-off-by: Breno Leitao Acked-by: Stanislav Fomichev