From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793756954; b=wMeIYwe+PZE4xwXvPIDF+xtzpDXIXFDHtC4d3khVt1PoPPqm21O7Z7GbsTej2XYKOBeg 558zt+bGJnRra4McFlAY3UNjkMtdMmLGrjpH4L0X37LIf/yOir+HoOJsVYFpqa9JfXpsB OupA8WH3ePfxPBZJQrfHDwIU3YO32QQhYPY3AD1zYjhPc3rjAJzsZU62SqKdkMkiTRs0n iraqpgrKSqPjeQ3eMoGX/dSUwV6dgkiyS3YqbBBWiymfs5FREguvFykzqz3w9tN6navvF IP9bBKzR4BcMDJB7RQrMKk4iuhTOdbFy6CzzH0GVWacliqc8zvErC9AHwGMcow41l7g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793756954; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=B9+nhlrF2Dcltc/b/gA0HI4sU+fSxvFt8AwHcya3lHg=; b=PsJGGDNv9NKzhpj9CzqamswXfZ6zcvSRUXEam+EGFPgm69QzjeHuX2BrP5wrvE/+pnXn gzyBnRfwicER0rcjsOEOeCzIWDj0u6tHIPD+qo5IFZiBvPJQLIXWC7T/NxPmQi8e3GV2C y1TAyTzc5xRSpoFlz4yVdlEz/qa7MxH5o1MAz2herzFk9hIX7yod6DDpiaPGtFtgp+Trd r3tGmrC9yltPPipkYu3gsA0lnZfRmZ+IJwFXtaeXZPPgqyquA0+Fvno0k6G7eey3Bua/v F8yREsAiH/t81wDRMWMgxVxvpRnXyLQBbjBdTQnD6a5/RBWhHsHYk1pwfgG110W/TZA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=WmgCd1z2; arc=none smtp.remote-ip=95.215.58.171 Received: from mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F320C606A328 for ; Wed, 4 Nov 2026 01:49:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F320C606A328 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=WmgCd1z2 X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=ly87kVwc8IX3qQC1upPNiV4ixKwflXWdxxSQPtJr530=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793756950; v=1; x=1794361750; b=WmgCd1z2xEwibpWazqwjfNFUMb/ti3JB4RI5g7fyRZsn46BHNv976oy8pudR2GVmIAJJvRtf TrX/RUMKekNCUJ4umRhO8sDe3MsN0lQ17l2YjLPHJ85Ak4zEfIrw99VzIKMHFgKZKG5V32FMRE8 5KvQHTjKsDF3UPgEh6FVAgSE= X-Envelope-To: netdev@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id bf8193c6aca9eaae; Wed, 04 Nov 2026 01:49:10 +0000 X-Mizu-Trace-ID: bf8193c6aca9eaae X-Migadu-Flow: FLOW_OUT Date: Wed, 4 Nov 2026 09:49:00 +0800 From: Hangbin Liu To: Sasha Levin Cc: Pablo Neira Ayuso , Florian Westphal , Phil Sutter , Fernando Fernandez Mancera , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Nathan Chancellor , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH nf-next] selftests: netfilter: nf_queue: drop the no-op loop initializer Message-ID: References: <20261103165419.687806-1-sashal@kernel.org> <20261103165419.687806-5-sashal@kernel.org> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261103165419.687806-5-sashal@kernel.org> On Tue, Nov 03, 2026 at 11:54:18AM -0500, Sasha Levin wrote: > The out-of-order verdict loop starts with "for (ooo_count; ...", and > clang warns about the unused expression: > > nf_queue.c:354:10: warning: expression result unused [-Wunused-value] > > Leave the initializer empty. > > Signed-off-by: Sasha Levin > --- > KernelCI's clang builds show this warning. > > tools/testing/selftests/net/netfilter/nf_queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/netfilter/nf_queue.c b/tools/testing/selftests/net/netfilter/nf_queue.c > index cca6c3cfa9e46..bc0b2f601a0a4 100644 > --- a/tools/testing/selftests/net/netfilter/nf_queue.c > +++ b/tools/testing/selftests/net/netfilter/nf_queue.c > @@ -351,7 +351,7 @@ static int mainloop(void) > if (opts.out_of_order) { > ooo_ids[ooo_count] = id; > if (ooo_count >= 15) { > - for (ooo_count; ooo_count >= 0; ooo_count--) { > + for (; ooo_count >= 0; ooo_count--) { > nlh = nfq_build_verdict(buf, ooo_ids[ooo_count], > opts.queue_num, opts.verdict); > if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { > -- > 2.53.0 > Reviewed-by: Hangbin Liu