From: Hangbin Liu <hangbin.liu@linux.dev>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, dsahern@kernel.org,
Ido Schimmel <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Andrea Parri <parri.andrea@gmail.com>,
Stanislav Fomichev <sdf.kernel@gmail.com>,
Nikolaos Gkarlis <nickgarlis@gmail.com>,
Willem de Bruijn <willemb@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/3] rtnetlink: return EMSGSIZE when first dump entry does not fit
Date: Wed, 18 Nov 2026 10:01:52 +0800 [thread overview]
Message-ID: <av0HEABXXzKVNnoU@fedora> (raw)
In-Reply-To: <20261117221538.184948-2-stephen@networkplumber.org>
Hi Stephen,
On Tue, Nov 17, 2026 at 02:13:42PM -0800, Stephen Hemminger wrote:
> If a route entry is too large for the dump skb, the dump is silently
> truncated and no error is returned.
>
> For handlers with RTNL_FLAG_DUMP_SPLIT_NLM_DONE, rtnl_dumpit() drops
> -EMSGSIZE and returns skb->len. With an empty skb this is 0, so the
> dump ends with NLMSG_DONE and status 0, and the remaining entries are
> lost.
>
> The first dump skb is allocated from __netlink_dump_start() while
> max_recvmsg_len is still 0, so it is only NLMSG_GOODSIZE. On a 4K page
> kernel that is under 4000 bytes, and a 500 way multipath route does not
> fit:
>
> ip link add dummy0 type dummy
> ip link set dummy0 up
> ip route add 198.51.100.0/24 table 100 \
> $(for i in $(seq 500); do echo -n "nexthop dev dummy0 "; done)
> ip route show table 100
>
> The dump prints nothing and exits 0
>
> Only ignore -EMSGSIZE when the skb has data, so that an entry which
> does not fit in an empty skb reports the error to user space.
>
> This only covers handlers which report a too large entry with
> -EMSGSIZE, such as the IPv4 FIB dump. inet6_dump_fib() instead returns
> a positive value when the first route does not fit, so the check added
> here never fires for it; that case is fixed by the next patch in this
> series.
>
> Fixes: 5b4b62a169e1 ("rtnetlink: make the "split" NLM_DONE handling generic")
Should we keep the Fixes tag or not for net-next?
Thanks
Hangbin
next prev parent reply other threads:[~2026-11-18 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 22:13 [PATCH net v3 0/3] rtnetlink: fix truncation of dump entry Stephen Hemminger
2026-11-17 22:13 ` [PATCH net-next v3 1/3] rtnetlink: return EMSGSIZE when first dump entry does not fit Stephen Hemminger
2026-11-18 2:01 ` Hangbin Liu [this message]
2026-11-17 22:13 ` [PATCH net-next v3 2/3] ipv6: return EMSGSIZE when first route in dump " Stephen Hemminger
2026-11-17 22:13 ` [PATCH net-next v3 3/3] selftests: net: netlink-dumps: test dump of route larger than skb Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av0HEABXXzKVNnoU@fedora \
--to=hangbin.liu@linux.dev \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nickgarlis@gmail.com \
--cc=pabeni@redhat.com \
--cc=parri.andrea@gmail.com \
--cc=sd@queasysnail.net \
--cc=sdf.kernel@gmail.com \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox