Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <hangbin.liu@linux.dev>
To: Andrea Mayer <andrea.mayer@uniroma2.it>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Hangbin Liu <liuhangbin@kylinos.cn>,
	Stefano Salsano <stefano.salsano@uniroma2.it>,
	Justin Iurman <justin.iurman@gmail.com>,
	Andrea Mayer <andrea@common-net.org>
Subject: Re: [PATCH net-next v3 5/5] selftests: seg6: add PSP flavor testing for SRv6 End.X
Date: Wed, 18 Nov 2026 15:06:38 +0800	[thread overview]
Message-ID: <av1OftpFCWPLimPx@fedora> (raw)
In-Reply-To: <20261118035010.e028076fbd99fbcddd937156@uniroma2.it>

Hi Andrea,
On Wed, Nov 18, 2026 at 03:50:10AM +0100, Andrea Mayer wrote:
> > > 
> > > Without NEXT-C-SID, get_rt_sid() drops the adjacency, as the Sashiko
> > > review also notes: "4>2:psp:End.X" and "4>3:psp:End.X" would both get
> > > fcff:4::0af1. I think each adjacency should have its own SID. The
> > > SID could carry the adjacency, as the C-SID already does. Then
> > > __setup_rt_policy() needs the new SID. Calling get_rt_sid() there,
> > > as suggested above, would do that.
> >
> > Hmm, do you want to set the adjacency like xaf1 or xxa1?
> > e.g. ffcf:4::2af1 for 4>2:psp:End.X, ffcf:4::3af1 for 4>3:psp:End.X
> > or
> > ffcf:4::42a1 for 4>2:psp:End.X, ffcf:4::43a1 for 4>3:psp:End.X?
> >
> > The second one may also need to adjust the End address. e.g.
> > fcff:x::ef1 -> fcff:x::e1
> 
> The first one you propose, fcff:4::2af1, seems reasonable. The adjacency
> takes the place of the leading 0 of the Function (0af1 -> 2af1). Towards
> the host the 0 stays, as in the C-SID, and the End SIDs do not change.

What about noflv? e.g. 3>4:noflv:End.X, should we use addr like
fcff:3::4a?

Thanks
Hangbin

      reply	other threads:[~2026-11-18  7:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  9:27 [PATCH net-next v3 0/5] seg6: add End.X PSP flavor support and selftests Hangbin Liu
2026-11-12  9:27 ` [PATCH net-next v3 1/5] seg6: split final End process out of flavor processing Hangbin Liu
2026-11-12  9:27 ` [PATCH net-next v3 2/5] seg6: add RFC8986 flavor support for End.X Hangbin Liu
2026-11-12  9:27 ` [PATCH net-next v3 3/5] selftests: seg6: move SRv6 End PSP setup into its own helper Hangbin Liu
2026-11-16  4:26   ` Andrea Mayer
2026-11-16  6:20     ` Hangbin Liu
2026-11-12  9:27 ` [PATCH net-next v3 4/5] selftest: seg6: explicit cleanup for SRv6 End PSP test Hangbin Liu
2026-11-16  4:34   ` Andrea Mayer
2026-11-16  6:27     ` Hangbin Liu
2026-11-16 12:29   ` netdev-bot+sashiko
2026-11-12  9:28 ` [PATCH net-next v3 5/5] selftests: seg6: add PSP flavor testing for SRv6 End.X Hangbin Liu
2026-11-16 12:29   ` netdev-bot+sashiko
2026-11-17  2:50   ` Andrea Mayer
2026-11-17  8:48     ` Hangbin Liu
2026-11-18  0:51       ` Hangbin Liu
2026-11-18  2:57         ` Andrea Mayer
2026-11-18  2:50       ` Andrea Mayer
2026-11-18  7:06         ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av1OftpFCWPLimPx@fedora \
    --to=hangbin.liu@linux.dev \
    --cc=andrea.mayer@uniroma2.it \
    --cc=andrea@common-net.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=justin.iurman@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@kylinos.cn \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stefano.salsano@uniroma2.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox