From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.209 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794993582; b=2nf6YzKjdfy8OR6nrqxFpq+E3c1uWOmzUPTK+3oEBnTJBDpWSIP+OWMA3FAqNJHN4c4W sbQMai88GelLH/ECCb0gmStxXRtdWdZvD8M3I2KIQczbVw00+Q4TMihwdeJg1UcGGfzGw cbLiywiU35tCpOq8xJacA2TVqXrl0nOz1twgLYxTQ07odrSoI4GQ1OMbP3u1iQgOb3cLo 1vQWHXC+fPU6IwF4809M1lCkh/mTkneB+81PVu+OiudyMO3dAJRXXDAYT8N1GGK3/1tSF OJW5GI6gPjS/8g9+i58+PYiuF7cdnfn5RTdShZ1DzMgr1kC+VkVoEso6F2w1J41pFDw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794993582; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=ri397ivyt6aPfQFFNso09dyLrQMfhGhibx0HBwogbaM=; b=0wXbeShXsvsc4febgxZ15lyL0XtFWmIClhyIm1KwN1n/h8viOrHcoMv7JLjgxUASWhWL J+dDPQiBvdg5wmuKB4h4YJBlMSGzLUX56FUdxtaAxM1yX37tYnJVFBV21ntBqIchB6TFC nmmGFy5NkUEJqEfBnGFAicifZ8fCtmXV9hOP5ANWNjz1oEw9hU0ZmbDjtVSBn3y6/Vf8K Tgge6E56mc7TFR4E26nRwMIajz4S4BjvoLiNp7OvN64PahyeT5K0cQ8YznKqhDYvzIgZh tpIj+4Q43AJh2GHf+ZUA6gUKGv2DDg/9o91b2GRriXBGUaliM0/l8Zf7GkzG+muVs9g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=PRn2oYbE; arc=none smtp.remote-ip=95.215.58.209 Received: from mta1.migadu.com (out-209.mta1.migadu.com [95.215.58.209]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B13D606A320 for ; Wed, 18 Nov 2026 09:19:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3B13D606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=PRn2oYbE X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=Yz7Wt5y85at5AxmKuuWhCUSqjxdfBYCurbD5eS1YmfU=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794993580; v=1; x=1795598380; b=PRn2oYbENfLPgMH7rdWqUIVdpLCQsd7QQYZNfW2Odh37z6+IsbFCYyKG1TC9IJFmzS4CyXkr yqIC4y3qBKfl4cg3vnyAy/K+RED+RV8EQCYu3hvUofM4jgl5lK0GORNEYp0f81/vIdJ69KPteEv R52est+iZkMBiRaCpWSXfKIs= X-Envelope-To: netdev@vger.kernel.org Received: by mta12.migadu.com with ESMTPS id a2db3085dd474efd; Wed, 18 Nov 2026 09:19:40 +0000 X-Mizu-Trace-ID: a2db3085dd474efd X-Migadu-Flow: FLOW_OUT Date: Wed, 18 Nov 2026 17:19:24 +0800 From: Hangbin Liu To: Andrea Mayer Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Hangbin Liu , Stefano Salsano , Justin Iurman , Andrea Mayer Subject: Re: [PATCH net-next v3 5/5] selftests: seg6: add PSP flavor testing for SRv6 End.X Message-ID: References: <20261112-srv6_flavors_endx-v3-0-c9177bbbd965@kylinos.cn> <20261112-srv6_flavors_endx-v3-5-c9177bbbd965@kylinos.cn> <20261117035021.e724668d726ecce54e091288@uniroma2.it> <20261118035010.e028076fbd99fbcddd937156@uniroma2.it> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Nov 18, 2026 at 03:06:38PM +0800, Hangbin Liu wrote: > Hi Andrea, > On Wed, Nov 18, 2026 at 03:50:10AM +0100, Andrea Mayer wrote: > > > > > > > > Without NEXT-C-SID, get_rt_sid() drops the adjacency, as the Sashiko > > > > review also notes: "4>2:psp:End.X" and "4>3:psp:End.X" would both get > > > > fcff:4::0af1. I think each adjacency should have its own SID. The > > > > SID could carry the adjacency, as the C-SID already does. Then > > > > __setup_rt_policy() needs the new SID. Calling get_rt_sid() there, > > > > as suggested above, would do that. > > > > > > Hmm, do you want to set the adjacency like xaf1 or xxa1? > > > e.g. ffcf:4::2af1 for 4>2:psp:End.X, ffcf:4::3af1 for 4>3:psp:End.X > > > or > > > ffcf:4::42a1 for 4>2:psp:End.X, ffcf:4::43a1 for 4>3:psp:End.X? > > > > > > The second one may also need to adjust the End address. e.g. > > > fcff:x::ef1 -> fcff:x::e1 > > > > The first one you propose, fcff:4::2af1, seems reasonable. The adjacency > > takes the place of the leading 0 of the Function (0af1 -> 2af1). Towards > > the host the 0 stays, as in the C-SID, and the End SIDs do not change. > > What about noflv? e.g. 3>4:noflv:End.X, should we use addr like > fcff:3::4a? Oh, I saw your example in the earlier reply. We should use the format like fcff:3::400a. No need to reply. Thanks Hangbin