From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794994842; b=bEF8CeysJjt7GWzigvyDViXy85bvLXFlgUOsfSm9AvIfKAES2VjJBt3RADi/fKDiqtS4 ebkhbJmS0eyMRyQ1bWeVgDL+Q2xkF5SEbDomubLEkF98WsICS9VZxdHHy8c7oCxQnLG// awBp7/2cJMNf/fItMXTAeWhcg5aV+SbD9Lvo8Qv0PWNVsRpf/JFn1K0J2WjhAiNemebgl 96LLOvpwmffw2aGazD341FyM7v5MZ5o4esS46H303z783ZrcL3EYNjLVe+qQPLFswC3X2 Z1dcvNmWrBEZp1C0pZk8AvZK+++i/J/8rmy2xnA/dA8CoE27H2Qgj61ZOUOikC8tdbA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794994842; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Date:From: To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Proofpoint-GUID: X-Proofpoint-ORIG-GUID:X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=jAyDX6sBJRescoz2h8Wju/7fXm9bYBb2dd0D5Xs+d9o=; b=Ua6/BDYEww6iAduif6KW/92tcxxN0Be/LE/ynN1Tup8nFSY70dQzNRzNMzNmuk7B4QVD C58D/oB9AMsW9ibtSMn39LsFttnoKe3d5eehkmaG0UE8YtwpAwPpyqyC55lRAb6Cp9V+l ysDaYypu2TGjDXQyno8WaA0vubpXiZ+TalOYHM8waqApV6iFWdTgWbSjOstBBHFkDXCa+ 3GSzWfXLmrVNBgNCMpDz/7U9W1xDB3hITAESia+p3kBqC0rrKFTfz1fVlhs/Coih1x/i7 Z3OdwFhIWp9DAU32GmPYxfJOubExffQYp+uwV+SIFC0cb7Ow036LplxAKBJoDo1Sgdg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ZcYNg8dh; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=FE+jOQHH; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DBF3606A32A for ; Wed, 18 Nov 2026 09:40:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8DBF3606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ZcYNg8dh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=FE+jOQHH Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AI8WhmW764106 for ; Wed, 18 Nov 2026 09:40:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=jAyDX6sBJRescoz2h8Wju/7f Xm9bYBb2dd0D5Xs+d9o=; b=ZcYNg8dhnRByell9a43mmmb6YmQfuKlErWPlGFA8 T93elM9UY8hEJnc0ty30Qp+2NJUHvhJ08cdQ344TanLKsvrVr/TBiIc7wCMS/m7Q 7GxvhtCAXYHo/7J6NitY8yJCkAl4CF6orJkn8MtayZ5UGSrhXwWYe9nNgUnDDeZM tsaDu2kNyS1tjLnvb/99CD7it1euLgpqMtfMNC8HWunt1JRLUQJP6H5c9yFFvB4r C7h2rmpybDaWMHQdS7IAWZutilrwYaAsgLpRi97+jMizmx6u8CGbMz1CJwv2Hhbu 3WsxU5uCSxaMfGL6UaB9pm2wz/CqXf+ND9S5S8FUVoxwvQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0yvbacch-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Nov 2026 09:40:40 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93f5844cb60so128530085a.0 for ; Wed, 18 Nov 2026 01:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794994840; x=1795599640; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jAyDX6sBJRescoz2h8Wju/7fXm9bYBb2dd0D5Xs+d9o=; b=FE+jOQHH1s3yBXIBaWm+wE2uYT5hpZVt/1bAt3EVHlZHOPMYYhdu4G4O6pByxMIwmx 82cbOxfdmb8U63p0XUMZ6tevnTPx9QYhpVlT8PcIP/B1ARKdX4yERuKKvtO4qxj/MNPq rDxq4qxBsGBnjnUsFDzE9ViXzjCZqDrZEyW/nRgHZzRcgKwoWGpjjRP3C+lufEs1uBFt c6BjE/lNfd46G+OyotyWmCbERKTULLZp7RdyIxfYY5UDPHnqO/12jU8LUPpKNTyUlVkz xNSckMoUgfMzyiLVvao97XJhS+UWl0Lm1BEQiUeRe8E/y3iak0jFbjBDO2zCPLDweJoE l5WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794994840; x=1795599640; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jAyDX6sBJRescoz2h8Wju/7fXm9bYBb2dd0D5Xs+d9o=; b=WTP76MDKPnB0rYqBktJctcQEffVmAdqqmo16qCiSrET92be+EMfKqR8bfh2irlLj8M R5jA9sBVgJMxg7isk/z1bh4TEL59R48Dqs2A/tZkFlIK1HlJvAaU1blZv7zWM2W0UcWR WROtcI6rDmotbhM7/qPpBP5yJqS+81Nbn9NPNQVDKQbZsXXnm+sNebreeBtTsdYCbC0F QdsZ2DjlSZli7o/AdeLpLl7nYFIOyGKEcxHVoLlCEQnmJACE2YKvVyl8gdPl3IIvnf0O XsS0Dw8HlQ0G/TMSr0b7FLbv605PrQK4MvLL5aOpNZhIEseKZRcSxTWC3bph/dIItU7k 403Q== X-Forwarded-Encrypted: i=1; AL+hErECny7tFZJXzxfapUpO3uAym3F01WyaFQJ7Hcug0RTCOf0yhDZl25F4h7dEnTwpJt3/7ME2w4k=@vger.kernel.org X-Gm-Message-State: APuU4Z/4t0yGKbbwaR7JrOK77LPETdGCbfN3vGeXUQ3xRV8T1VuZ7VKt dAqRRBha0gg1wrOyLAsHHDUIGgeQelv4KiyEr0lM7bqnIfl4nwcQ2pecNgCczexduzaXIsBVDJh uyr2jSTfNQnijPgNdBhNOPIkXY7E3yI8X9hNysdFLs6I3j3RkrTTNb66Dz+s= X-Gm-Gg: AYBFou1MFx4skS4t6oncctUswpcMp3wxaPDc1eFfL4rjRm1A4yb79ypTcKzlX7N+Fk0 mOXZWRLSWfnhtKVuAJ2k8w9fWcKPOkQe8ZrlQRvipVC9h+TbSpBU1iPbQRa9DQRtQc87rCAwNCi an941kWS5M2VkBQPIgxnCLygsnOCn8bnZcdJhYszvtNbsg0vd+auXNfxlwJyegDSbKTcDCJ/VBg mrxq1Mg/cmX2dBJI8rcKgbUuiSSRxfZKYTYWJ/4KOam+EV/QBYP+KWfDMp6sOZSX2WEVSBqz9iq SD4eQlgFffYtat34og0s/+TH7dmMUqX1qlaOWYRSeyRxsK0PlqKn6GWAk/kndD8krEsQjRJj8R1 J4XV4go8+HuEsioWdfT311/jSRtXZnr+JbE9MXuJ9V8SMAPHc5L/OXZhF4SpGuTk= X-Received: by 2002:a05:620a:2606:b0:93e:c12d:4ecc with SMTP id af79cd13be357-9498b9a52bdmr798026685a.44.1794994839449; Wed, 18 Nov 2026 01:40:39 -0800 (PST) X-Received: by 2002:a05:620a:2606:b0:93e:c12d:4ecc with SMTP id af79cd13be357-9498b9a52bdmr798020185a.44.1794994838774; Wed, 18 Nov 2026 01:40:38 -0800 (PST) Received: from localhost ([195.50.164.66]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb78422d2dsm190598255e9.10.2026.11.18.01.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:40:37 -0800 (PST) Date: Wed, 18 Nov 2026 10:40:35 +0100 From: Lorenzo Bianconi To: Mohd Ayaan Anwar Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v4 08/10] net: stmmac: qcom-ethqos: add per-platform NOC clock voting Message-ID: References: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> <20261117-shikra_ethernet-v4-8-c41902e5f2fa@oss.qualcomm.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sQAqpoQJ5wAuuY31" Content-Disposition: inline In-Reply-To: <20261117-shikra_ethernet-v4-8-c41902e5f2fa@oss.qualcomm.com> X-Proofpoint-GUID: zuOZs663ih4XyIDS0T_wDujdZP7_7-Fw X-Proofpoint-ORIG-GUID: zuOZs663ih4XyIDS0T_wDujdZP7_7-Fw X-Authority-Analysis: v=2.4 cv=YfgodARf c=1 sm=1 tr=0 ts=6afd7298 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Jk2/TV77q6/E6wQq2oQJxQ==:17 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=okzICtKxooRRR1VLav4A:9 a=CjuIK1q_8ugA:10 a=Dhi2dq_hunc8pPVQk9UA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE4MDAzOCBTYWx0ZWRfXz5gFxAzlVy9w khZT1I7Fw6QqGDFP0pa7OD6HjkRZWUg82fkslrF9NEGVU7CgE0RwNbwZAvcow2Ryk3IzxdPVHJg sKBHJveS+EKyeOTfnnfv7l+Ti6ts5r4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE4MDAzOCBTYWx0ZWRfXwbWBT///bZFV lCZKw+QKPaZVc2iKi8I+F24fyPeojCVXg8GMXJTkjCRUU4I5ARxGp3OWKiFhckvYbSiD1eXDzqF kRPMmfWHNIrkyzVVMjL90MNDmACNlAVfMBm8DiLy66SF2xIoqLdmIa8+2577KOLdrZXUWpRFq3F ZH22I2xX7aZj1bDB6sqpuZCzDQL+6JxboyeGXjBHhPjgy7Z5ARTHloDm6b+NPwr9sD2MyChAjJ8 PPuE407oXHiIfuOcLjkI5tvANHPmTrR31GX3boXXf/Qv35yZR2IVveNIcgCC3LvS1exr3zVVgxR lQYsOhbb5NT/p0C/RffJXNIHRerBJ/QbExl4FtzmNs7D4zYcWkT0QnwEHXNp14yEEHVBiZrRGFo 5t26vjONJ3z51Wr6cldHKNUOoag2EFvk9h8LSqhzFYwiMBXVHjMRivwyk8k8705cJd4j54Qnu3B 1kd3kTz5gX3+Av1US1w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-18_01,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611180038 --sQAqpoQJ5wAuuY31 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Some SoCs gate the EMAC DMA path behind dedicated AXI clocks. Add > per-platform clock-name lists and configure them as a single > multi-clock OPP. The OPP core programs every clock rate and propagates > the required power state. >=20 > Select PM_OPP because DWMAC_QCOM_ETHQOS calls PM OPP APIs for > compatibles that describe AXI OPP clocks. >=20 > No functional change for existing compatibles. This will help us when > we add support for Shikra. >=20 > Signed-off-by: Mohd Ayaan Anwar Hi Mohd, just a nit inline. Fixing it: Reviewed-by: Lorenzo Bianconi Regards, Lorenzo > --- > drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 + > .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 103 +++++++++++++++= ++++++ > 2 files changed, 104 insertions(+) >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/et= hernet/stmicro/stmmac/Kconfig > index c6559e749c0c..15639666e837 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > @@ -146,6 +146,7 @@ config DWMAC_QCOM_ETHQOS > tristate "Qualcomm ETHQOS support" > default ARCH_QCOM > depends on OF && (ARCH_QCOM || COMPILE_TEST) > + select PM_OPP > help > Support for the Qualcomm ETHQOS core. > =20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/dr= ivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index bc443793539b..15385750b3e6 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > =20 > @@ -102,6 +103,8 @@ struct ethqos_emac_driver_data { > const char *link_clk_name; > const struct dwmac4_addrs *dwmac4_addrs; > bool needs_sgmii_loopback; > + const char * const *noc_clk_names; > + unsigned int num_noc_clks; > /* Fixed PTP reference clock rate, used on SCMI platforms where > * firmware does not implement the clock protocol allowing linux to > * query it. > @@ -119,6 +122,8 @@ struct qcom_ethqos { > phy_interface_t phy_mode; > struct dev_pm_domain_list *pds; > const struct ethqos_emac_driver_data *data; > + struct clk_bulk_data *noc_clks; > + unsigned int num_noc_clks; > }; > =20 > static u32 rgmii_readl(struct qcom_ethqos *ethqos, unsigned int offset) > @@ -725,18 +730,61 @@ static int ethqos_mac_finish_serdes(struct net_devi= ce *ndev, void *priv, > return ret; > } > =20 > +static int qcom_ethqos_set_opp(struct qcom_ethqos *ethqos) is it clearer to have an utility routine to set a specific freq and then ca= ll it with freq =3D ULONG_MAX? Something like: static in t qcom_ethqos_set_opp(struct qcom_ethqos *ethqos, unsigned long *= freq) { .... } > +{ > + struct device *dev =3D ðqos->pdev->dev; > + unsigned long freq =3D ULONG_MAX; > + struct dev_pm_opp *opp; > + int ret; > + > + opp =3D dev_pm_opp_find_freq_floor_indexed(dev, &freq, 0); > + if (IS_ERR(opp)) { > + ret =3D PTR_ERR(opp); > + dev_err(dev, "Failed to find AXI NOC OPP: %d\n", ret); > + return ret; > + } > + > + ret =3D dev_pm_opp_set_opp(dev, opp); > + dev_pm_opp_put(opp); > + > + return ret; > +} > + > static int ethqos_clks_config(void *priv, bool enabled) > { > struct qcom_ethqos *ethqos =3D priv; > int ret =3D 0; > =20 > if (enabled) { > + if (ethqos->num_noc_clks) { > + ret =3D qcom_ethqos_set_opp(ethqos); > + if (ret) { > + dev_err(ðqos->pdev->dev, > + "NOC OPP set failed: %d\n", ret); > + return ret; > + } > + } > + > ret =3D clk_prepare_enable(ethqos->link_clk); > if (ret) { > dev_err(ðqos->pdev->dev, "link_clk enable failed\n"); > + if (ethqos->num_noc_clks) > + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); > return ret; > } > =20 > + if (ethqos->num_noc_clks) { > + ret =3D clk_bulk_prepare_enable(ethqos->num_noc_clks, > + ethqos->noc_clks); > + if (ret) { > + dev_err(ðqos->pdev->dev, > + "NOC clocks enable failed: %d\n", ret); > + clk_disable_unprepare(ethqos->link_clk); > + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); > + return ret; > + } > + } > + > /* Enable functional clock to prevent DMA reset to timeout due > * to lacking PHY clock after the hardware block has been power > * cycled. The actual configuration will be adjusted once > @@ -745,7 +793,12 @@ static int ethqos_clks_config(void *priv, bool enabl= ed) > qcom_ethqos_set_sgmii_loopback(ethqos, true); > ethqos_set_func_clk_en(ethqos); > } else { > + if (ethqos->num_noc_clks) > + clk_bulk_disable_unprepare(ethqos->num_noc_clks, > + ethqos->noc_clks); > clk_disable_unprepare(ethqos->link_clk); > + if (ethqos->num_noc_clks) > + dev_pm_opp_set_rate(ðqos->pdev->dev, 0); > } > =20 > return ret; > @@ -773,6 +826,52 @@ static void ethqos_ptp_clk_freq_config(struct stmmac= _priv *priv) > netdev_dbg(priv->dev, "PTP rate %lu\n", plat_dat->clk_ptp_rate); > } > =20 > +static void qcom_ethqos_noc_opp_cleanup(void *dev) > +{ > + dev_pm_opp_set_rate(dev, 0); > +} > + > +/* Some SoCs gate NOC access behind dedicated clocks. Acquire them here > + * and set up an OPP table to vote for the required rate and power. > + */ > +static int qcom_ethqos_init_noc_clks(struct qcom_ethqos *ethqos, > + const struct ethqos_emac_driver_data *data) > +{ > + struct dev_pm_opp_config config =3D { > + .clk_names =3D data->noc_clk_names, > + .config_clks =3D dev_pm_opp_config_clks_simple, > + }; > + struct device *dev =3D ðqos->pdev->dev; > + unsigned int i; > + int ret; > + > + if (!data->num_noc_clks) > + return 0; > + > + ethqos->noc_clks =3D devm_kcalloc(dev, data->num_noc_clks, > + sizeof(*ethqos->noc_clks), GFP_KERNEL); > + if (!ethqos->noc_clks) > + return -ENOMEM; > + > + for (i =3D 0; i < data->num_noc_clks; i++) > + ethqos->noc_clks[i].id =3D data->noc_clk_names[i]; > + ethqos->num_noc_clks =3D data->num_noc_clks; > + > + ret =3D devm_clk_bulk_get(dev, ethqos->num_noc_clks, ethqos->noc_clks); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to get NOC clocks\n"); > + > + ret =3D devm_pm_opp_set_config(dev, &config); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to configure OPP clocks\n"); > + > + ret =3D devm_pm_opp_of_add_table(dev); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to add OPP table\n"); > + > + return devm_add_action_or_reset(dev, qcom_ethqos_noc_opp_cleanup, dev); > +} > + > static int ethqos_hlos_setup(struct qcom_ethqos *ethqos, > struct plat_stmmacenet_data *plat_dat) > { > @@ -780,6 +879,10 @@ static int ethqos_hlos_setup(struct qcom_ethqos *eth= qos, > struct device *dev =3D &pdev->dev; > int ret; > =20 > + ret =3D qcom_ethqos_init_noc_clks(ethqos, ethqos->data); > + if (ret) > + return ret; > + > ethqos->rgmii_base =3D devm_platform_ioremap_resource_byname(pdev, "rgm= ii"); > if (IS_ERR(ethqos->rgmii_base)) > return dev_err_probe(dev, PTR_ERR(ethqos->rgmii_base), >=20 > --=20 > 2.34.1 >=20 --sQAqpoQJ5wAuuY31 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCav1ykwAKCRA6cBh0uS2t rNQBAP4lJiuirwRLFVe8XvEt5fSxZrB9fn9Cj/z3AcKiRIBcEAEA+hNM2boDyzWS OuhgaeR4bNxOJR5Y8qmsH2GTsrvmiAU= =y4oA -----END PGP SIGNATURE----- --sQAqpoQJ5wAuuY31--