From: Joe Damato <joe@dama.to>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,
netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, pavan.chebbi@broadcom.com,
linux-kernel@vger.kernel.org,
Selvin Xavier <selvin.xavier@broadcom.com>
Subject: Re: [PATCH net v5 0/4] bnxt_en: Make RING FREE more robust
Date: Thu, 19 Nov 2026 07:15:46 -0800 [thread overview]
Message-ID: <av8Soqh/haOS3/JL@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <CACKFLimpUYgcV8VW_wFN5Bm+4cb-4eE=LGtp+9QO5dxAShBgCg@mail.gmail.com>
On Tue, Nov 17, 2026 at 03:04:09PM -0800, Michael Chan wrote:
> On Tue, Nov 17, 2026 at 8:10 AM Joe Damato <joe@dama.to> wrote:
> > One more question before I put together v6.
> >
> > bnxt_reset() is also called for the silent reset on a VF: the
> > VF_CFG_CHANGE async event sets BNXT_RESET_TASK_SILENT_SP_EVENT, and
> > bnxt_sp_task() calls bnxt_reset(bp, true). With the ULP patch as planned,
> > RoCE on the VF would be stopped and restarted every time the PF changes
> > that VF's config.
> >
> > Not sure how often config changes happen with RoCE in use on VFs? If not
> > often, then treating silent and non-silent resets the same should be OK.
> > The cost is a brief RoCE restart on the VF for every config change.
> >
>
> VF_CFG_CHANGE is to notify the VF about changes such as default VLAN.
> Unlike a TX timeout, this is a normal config change and I think we
> shouldn't disrupt RoCE unnecessarily. It's unlikely to run into
> errors during the config change. Selvin and Kalesh, please comment as
> well. Thanks.
I didn't hear back from Selvin of Kalesh, but I think we discussed enough in
this thread that I can put together a reasonable v6 that (I hope) will be
acceptable.
prev parent reply other threads:[~2026-11-19 15:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 19:14 [PATCH net v5 0/4] bnxt_en: Make RING FREE more robust Joe Damato
2026-11-06 19:14 ` [PATCH net v5 1/4] bnxt_en: return the RING_FREE status to callers Joe Damato
2026-11-07 19:58 ` netdev-bot+sashiko
2026-11-09 17:45 ` Joe Damato
2026-11-09 18:26 ` Michael Chan
2026-11-06 19:14 ` [PATCH net v5 2/4] bnxt_en: check HWRM response if completion never arrives Joe Damato
2026-11-07 19:58 ` netdev-bot+sashiko
2026-11-09 18:05 ` Joe Damato
2026-11-06 19:14 ` [PATCH net v5 3/4] bnxt_en: stop DMA before releasing rings the firmware did not free Joe Damato
2026-11-07 19:58 ` netdev-bot+sashiko
2026-11-09 19:52 ` Joe Damato
2026-11-06 19:14 ` [PATCH net v5 4/4] bnxt_en: refuse to open a device with stopped DMA Joe Damato
2026-11-07 19:58 ` netdev-bot+sashiko
2026-11-09 20:01 ` Joe Damato
2026-11-09 20:12 ` [PATCH net v5 0/4] bnxt_en: Make RING FREE more robust Joe Damato
2026-11-10 0:13 ` Michael Chan
2026-11-10 17:39 ` Joe Damato
2026-11-10 18:14 ` Michael Chan
2026-11-10 22:13 ` Joe Damato
2026-11-10 23:04 ` Michael Chan
[not found] ` <CAH-L+nOyNgAUMCF74OE+oU2gSCaV_tVcgm2QQFvjge10A+qAYg@mail.gmail.com>
2026-11-17 16:10 ` Joe Damato
2026-11-17 23:04 ` Michael Chan
2026-11-19 15:15 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8Soqh/haOS3/JL@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox