From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.229.133 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794439264; b=ggOz0XKESiv5mjYEPxubcGvDhx260Tgl1snsUX1iQFe+cf2YlzTUDqm/gLIc0SbXswj6 fy0jG7dkDNfoc3/I4MGiTGl3R+GuoQ+kbBNH7AjcF4s01Hz9/pLX2wGyVf2JiPs/hob6q UkVLPoRO6hbwowD/DRPROfrhm4iHU+qfvrtiH9eGSGJtksTbAdABpdt+8D9U7bxMVNkQF kv5bQOgdb+DR4GrfY7Ck2NWeQUQq8DET0Qy9BeDOF5/REVLb1+/e/PUZyQoBssbwL8nwQ dP5rO7P6FVSAdb5aV/o89EjtkdkqjC6wgoIYJqhDrj3M8HiUtGJCNQ79nNa5b4ZsOPA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794439264; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=eE9X9IsI4DGKfcKaEqbUpAyTJeGhuPKiIV6pCis8+mc=; b=lAKSF8vo3iWt5geRZHf22yqoBbuKCXCjTAjYFyavPKYY5xMPHh8QE22hrZ188wMLVu8T yL44Ytre0OGZcByktf8Cnima6qBe6uPjv5JSMqS+VVZq3rCtDIX9b48i3jyzDXV61nkqt 7ocTh2rKaO/y/MmU+2ueVo6IHbWdMLhXACx12pQTQ/HwlYp2u3VI1QDqxrpOXYJ+G9PEh +SPVhbgk0vX7aXrHWm15u4LMX0K97AW5sNfOaJ5tMuow26DToPsaNJ903rpuLkBQlGQE8 HGi/AyJClctRnMHCJ/HQr6uCl7N6A25zQVBEeWbxcLhTvd/o0y2Om8p70sSBj4QIkbw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=AS4FCx2D; arc=none smtp.remote-ip=74.125.229.133 Received: from mail-dl2-f5.google.com (mail-dl2-f5.google.com [74.125.229.133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D522A606A8AB for ; Wed, 11 Nov 2026 23:21:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D522A606A8AB Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=AS4FCx2D Received: by mail-dl2-f5.google.com with SMTP id a92af1059eb24-1ac216daf7dso2074492c88.1 for ; Wed, 11 Nov 2026 15:21:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794439263; x=1795044063; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=eE9X9IsI4DGKfcKaEqbUpAyTJeGhuPKiIV6pCis8+mc=; b=AS4FCx2Dzy3knLqQU0KfBNqF5KUSlkLF7ulR+nDPovTotbPJqyuHWJZbdiqD0hnert Fjrod0191CeZY5GKnOqJQFXEdEHnEc9RnGOSGH5h4p748bHPLDNJ0byXo7dSycqqcU13 OyILZU4dK6tcd2Ci05DZ8FF8yEvMkGJErFQBNpoVdDDqtfOvSHLZqPU/NPmpqdQ/5ur1 G0ewEQXkjx0av1/XfhNJuB0qBTb2u6LImLfzoX4gBMIL2Eoag2sL2m+gsCjyN778IkpV 3mYuBiwwgs25VP7eFbwR1g1h0EZbnCDVpu2l2LNGRuQnz/SV5so618qySg3qt6ExWr2C Jtpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794439263; x=1795044063; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=eE9X9IsI4DGKfcKaEqbUpAyTJeGhuPKiIV6pCis8+mc=; b=E36SndCNdu8ut6TQEGmhOgxbZSAHybG8inM9OxzsGXJS2mXoCInoXjgeFqg7/fx0tJ v3ehbSz2nOT4g4sbG7Lwgb4rt16BExiRIB4tiUB1sS2kgU/8pLkk7jKkqEx+hTsSfHoD 2EbvGZ5TmMzKu87fZeLvBzs0ilvuK62Rw6MDU+6ealQ0IQ+niiWc4Mf7hcWayiFv6WE4 sryB/gk+o5K/mcDq+X3qLv2zP0UfMoV0yyL832vWN31Ay2hGKk4Rd0dDlpyIAHz1wmLg tusn5zgiOi0tbe+uJ9u23C7hh5CH9XvNGL6dmIBz+OrEcmT9VYwq7wblXA2r8lVNyT0K Id9Q== X-Forwarded-Encrypted: i=1; AL+hErFz3UCLiFWIKzX8ubfgLxxQsIH+9WpMl5O1BYucewgHIEubJztDfaW4psD+POnP56bn0sd6Cj8=@vger.kernel.org X-Gm-Message-State: APuU4Z+PTHyxVtycVITaoJkEe4/FX4BVEg31B6cHUxkI93wcT75GPMe1 TYnM43AI3Vii6TmfPuoAtYvHdwELzrqdOsFHw3nVGMGPq4Etr3dG8wre X-Gm-Gg: AYBFou3Yat3pynzxQAH20wqdriWc9sYk2jU+uUp32FJxvdk/qEso0zVr20T2/AfO1vm EZSCi/Rkf/CezEiEH9bn52MgnHXdj0ty6bQIm4g3bpNBQ+Djp141Yjaua7AlLAmPrgkXj28Xmok 7akHQaiG2DjDIy44bDa3OWUhN92hkaEjLKtj0rXAbYbcReryC2xCOgR9BfFvrf/1/sLDJ6E6Q3R qMuqdwT7T8ex90+IRLVPsvzXrG1wZ7//AmcmBWiA0EKVPFBv4niqM7O1qVz6IbOeRojGa86M3Qx aZ7SQIi6M4BjHRk8HJbpBkMFBq2Ju8ck+ou4Kn2nED9MuKc7wE+Jlj9PcedsnHyxKmWkdcm3S3J EHu9jS0I1ZxkRo8WpGYOCzE4HT2gjhqOIcakcZNUVVSy9NbZ5DXM2o19vj22mtRADspXYoUs58p bNAvS3eOK6gCow+ae6cYneUZEjIEyvazRRy+oDavEIZ+/e+nB/2/ymZfMrvNEpwT8CSw8f0DqTo qd2OQHkmoiPDXRuBe4IOibA3SYlW7mN+bMtJ738IbcYvniSSRQDV9XIeRSp0HRNI0mh0fmu7JQf /SUrpX6YYxmbGUeEE8sD1U4= X-Received: by 2002:a05:7300:1899:b0:376:b957:c01 with SMTP id 5a478bee46e88-376b9570fd3mr5155040eec.16.1794439263001; Wed, 11 Nov 2026 15:21:03 -0800 (PST) Received: from localhost ([2a03:2880:9ff:66::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3751fe2ff5dsm19921294eec.5.2026.11.11.15.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 15:21:02 -0800 (PST) Date: Wed, 11 Nov 2026 15:05:25 -0800 From: Stanislav Fomichev To: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Alexander Duyck , kernel-team@meta.com, Andrew Lunn , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Pavel Begunkov , Jens Axboe , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , netdev@vger.kernel.org, bpf@vger.kernel.org, io-uring@vger.kernel.org, Mina Almasry , "Mike Marciniszyn (Meta)" , Weiming Shi , Nikolay Aleksandrov , David Wei , Alexander Lobakin , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Stuart Clark Subject: Re: [PATCH net-next v1 03/11] xdp: Copy buffers with restricted lifetime Message-ID: References: <20261110102039.1002605-1-bjorn@kernel.org> <20261110102039.1002605-4-bjorn@kernel.org> <87eccra46g.fsf@all.your.base.are.belong.to.us> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87eccra46g.fsf@all.your.base.are.belong.to.us> On 11/11, Björn Töpel wrote: > Stanislav Fomichev writes: > > > On 11/10, Björn Töpel wrote: > > >> diff --git a/include/net/xdp.h b/include/net/xdp.h > >> index 07231adfb5f8..1105bb9e3292 100644 > >> --- a/include/net/xdp.h > >> +++ b/include/net/xdp.h > >> @@ -81,6 +81,16 @@ enum xdp_buff_flags { > >> * XDP program is not attached. > >> */ > >> XDP_FLAGS_FRAGS_UNREADABLE = BIT(2), > >> + /* Internal: the head netmem and the shared info are in &xdp_buff.ext. > >> + * Not copied to xdp_frames or skbs. > >> + */ > >> + XDP_FLAGS_EXT = BIT(3), > >> +}; > >> + > >> +/* For a head buffer that cannot hold kernel data, see xdp_init_buff_netmem() */ > >> +struct xdp_buff_ext { > >> + netmem_ref netmem; > > > > nit: netmem -> head ? and the same for xdp_init_buff_netmem netmem arg? > > Yup, will fix. > > >> @@ -138,7 +153,7 @@ static __always_inline void xdp_buff_set_frag_unreadable(struct xdp_buff *xdp) > >> > >> static __always_inline u32 xdp_buff_get_skb_flags(const struct xdp_buff *xdp) > >> { > >> - return xdp->flags; > >> + return xdp->flags & ~XDP_FLAGS_EXT; > > > > The only consumer is xdp_update_skb_frags_info, so probably not worth > > filtering out XDP_FLAGS_EXT here? Or is it for > > xdp_update_frame_from_buff? Can we explicitly clear it at the caller? > > It was for xdp_update_frame_from_buff(), but looking closer EXT never > gets there... > > I'll drop the mask. Thanks! > > >> diff --git a/net/core/devmem.c b/net/core/devmem.c > >> index 8f190b574beb..dea4a4a17e86 100644 > >> --- a/net/core/devmem.c > >> +++ b/net/core/devmem.c > >> @@ -698,5 +698,5 @@ static const struct memory_provider_ops dmabuf_devmem_ops = { > >> .release_netmem = mp_dmabuf_devmem_release_page, > >> .nl_fill = mp_dmabuf_devmem_nl_fill, > >> .uninstall = mp_dmabuf_devmem_uninstall, > >> - .caps = MP_CAP_FRAG, > >> + .caps = MP_CAP_FRAG | MP_CAP_RETAIN, > > > > Not sure I understand this part, can you explain? > > These are MP_CAP_RETAIN because they are unreadable? > > No, RETAIN is about lifetime: the stack may hold page pool references > after the RX poll, e.g. skbs on a TCP receive queue. That's how devmem > and zcrx work; without it the stack would try to copy them, and they'd > trip the DEBUG_NET check in skb_add_rx_frag_netmem(). > > A provider without RETAIN gets copied, so it must be readable. I'll try > to make that more clear in the kdoc, and probably refuse a provider that > is neither. Ah, yes, thanks, I did miss that warn in skb_add_rx_frag_netme, makes sense!