From: Florian Westphal <fw@strlen.de>
To: "Jérémy Jean" <Jeremy.Jean@oss.cyber.gouv.fr>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v4 2/2] xfrm: fix selector matching for IPv6 atomic fragments
Date: Thu, 12 Nov 2026 14:20:58 +0100 [thread overview]
Message-ID: <avW9OrfvkAF99uP_@strlen.de> (raw)
In-Reply-To: <20261109213803.1785516-6-Jeremy.Jean@oss.cyber.gouv.fr>
Jérémy Jean <Jeremy.Jean@oss.cyber.gouv.fr> wrote:
> + if ((flkeys.control.flags & FLOW_DIS_IS_FRAGMENT) &&
> + ipv6_find_hdr(skb, &offset, -1, NULL, &fh_flags) >= 0 &&
> + (fh_flags & IP6_FH_F_FRAG) &&
> + !(fh_flags & IP6_FH_F_NON_ATOMIC)) {
Since you need to send a new version anyway, maybe avoid
double-neg, i.e.: (fh_flags & IP6_FH_F_ATOMIC) ?
next prev parent reply other threads:[~2026-11-12 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 21:38 [PATCH net v4 0/2] xfrm: fix IPv6 atomic fragment policy handling Jérémy Jean
2026-11-09 21:38 ` [PATCH net v4 1/2] xfrm: fix IPv6 first-fragment protocol decode Jérémy Jean
2026-11-09 21:38 ` [PATCH net v4 2/2] xfrm: fix selector matching for IPv6 atomic fragments Jérémy Jean
2026-11-12 12:39 ` netdev-bot+sashiko
2026-11-12 13:20 ` Florian Westphal [this message]
2026-11-12 13:33 ` Jérémy Jean
2026-11-09 22:56 ` [PATCH net v4 0/2] xfrm: fix IPv6 atomic fragment policy handling netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avW9OrfvkAF99uP_@strlen.de \
--to=fw@strlen.de \
--cc=Jeremy.Jean@oss.cyber.gouv.fr \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=idosch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox