Netdev List
 help / color / mirror / Atom feed
From: "Alvin Šipraga" <alvin.sipraga@analog.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Luiz Angelo Daros de Luca <luizluca@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH net-next v2 00/10] net: dsa: realtek: rtl8365mb: DCB ingress QoS offload
Date: Fri, 13 Nov 2026 13:24:28 +0100	[thread overview]
Message-ID: <avbP8aF77eg1iCPR@analog.com> (raw)
In-Reply-To: <20261112-rtl8365mb-dcb-ingress-v2-0-f8e6fbdf8c99@pengutronix.de>

On Thu, Nov 12, 2026 at 09:37:43AM +0100, Oleksij Rempel wrote:
> Add ingress QoS offload for the RTL8365MB switch through the dcbnl app
> interface: a per-port default priority, PCP trust and DSCP trust. The
> mapping helpers go to net/core/ieee8021q_helpers.c so other drivers
> can share them.
> 
> Two changes are visible to users. The driver now rejects a devicetree
> port that the chip does not have. With a default priority set, an
> untagged frame that leaves a VLAN-tagged port carries that priority as
> its PCP.
> 
> Tested on an RTL8365MB-VC with eight queues.
> 
> ETS scheduling and CPU-tag pre-classification will follow in separate
> series.
> 
> v1:
> https://lore.kernel.org/r/20261002115850.962676-1-o.rempel@pengutronix.de
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Notwithstanding my other comment, the whole thing looks good! So for the
series:

Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>

> ---
> Oleksij Rempel (10):
>       net: ieee8021q: print traffic type and queue count with %u
>       net: ieee8021q: add pcp_to_tt()
>       net: ieee8021q: clarify the tt_to_tc() traffic-class mapping
>       net: ieee8021q: add tt_to_pcp()
>       net: dsa: realtek: rtl8365mb: describe the ports of each chip
>       net: dsa: realtek: rtl8365mb: store the egress queue count per chip
>       net: dsa: realtek: rtl8365mb: add QoS baseline and DCB default prio
>       net: dsa: realtek: rtl8365mb: program the PCP of untagged frames
>       net: dsa: realtek: rtl8365mb: offload DCB apptrust
>       net: dsa: realtek: rtl8365mb: report the DCB DSCP-to-priority map
> 
>  drivers/net/dsa/realtek/Kconfig          |   1 +
>  drivers/net/dsa/realtek/Makefile         |   5 +-
>  drivers/net/dsa/realtek/realtek.h        |  32 ++
>  drivers/net/dsa/realtek/rtl8365mb_main.c |  70 ++++-
>  drivers/net/dsa/realtek/rtl8365mb_qos.c  | 507 +++++++++++++++++++++++++++++++
>  drivers/net/dsa/realtek/rtl8365mb_qos.h  |  33 ++
>  drivers/net/dsa/realtek/rtl83xx-qos.c    | 209 +++++++++++++
>  drivers/net/dsa/realtek/rtl83xx-qos.h    |  20 ++
>  include/net/ieee8021q.h                  |  21 +-
>  net/core/ieee8021q_helpers.c             | 103 ++++++-
>  10 files changed, 979 insertions(+), 22 deletions(-)
> ---
> base-commit: fa5196392691051963726787944db872420dfa75
> change-id: 20261109-rtl8365mb-dcb-ingress-0dae31a02c0f
> 
> Best regards,
> -- 
> Oleksij Rempel <o.rempel@pengutronix.de>
> 

      parent reply	other threads:[~2026-11-13 12:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  8:37 [PATCH net-next v2 00/10] net: dsa: realtek: rtl8365mb: DCB ingress QoS offload Oleksij Rempel
2026-11-12  8:37 ` [PATCH net-next v2 01/10] net: ieee8021q: print traffic type and queue count with %u Oleksij Rempel
2026-11-12  8:37 ` [PATCH net-next v2 02/10] net: ieee8021q: add pcp_to_tt() Oleksij Rempel
2026-11-12  8:37 ` [PATCH net-next v2 03/10] net: ieee8021q: clarify the tt_to_tc() traffic-class mapping Oleksij Rempel
2026-11-12  8:37 ` [PATCH net-next v2 04/10] net: ieee8021q: add tt_to_pcp() Oleksij Rempel
2026-11-12  8:37 ` [PATCH net-next v2 05/10] net: dsa: realtek: rtl8365mb: describe the ports of each chip Oleksij Rempel
2026-11-12 15:08   ` Alvin Šipraga
2026-11-12 20:38   ` Linus Walleij
2026-11-12  8:37 ` [PATCH net-next v2 06/10] net: dsa: realtek: rtl8365mb: store the egress queue count per chip Oleksij Rempel
2026-11-12  8:37 ` [PATCH net-next v2 07/10] net: dsa: realtek: rtl8365mb: add QoS baseline and DCB default prio Oleksij Rempel
2026-11-12 20:31   ` Linus Walleij
2026-11-12  8:37 ` [PATCH net-next v2 08/10] net: dsa: realtek: rtl8365mb: program the PCP of untagged frames Oleksij Rempel
2026-11-12 20:33   ` Linus Walleij
2026-11-12  8:37 ` [PATCH net-next v2 09/10] net: dsa: realtek: rtl8365mb: offload DCB apptrust Oleksij Rempel
2026-11-12 20:35   ` Linus Walleij
2026-11-12  8:37 ` [PATCH net-next v2 10/10] net: dsa: realtek: rtl8365mb: report the DCB DSCP-to-priority map Oleksij Rempel
2026-11-12 20:36   ` Linus Walleij
2026-11-13 12:24 ` Alvin Šipraga [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avbP8aF77eg1iCPR@analog.com \
    --to=alvin.sipraga@analog.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luizluca@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox