From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Julian Anastasov <ja@ssi.bg>
Cc: netdev-bot+sashiko@kernel.org, netfilter-devel@vger.kernel.org,
davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
pabeni@redhat.com, edumazet@kernel.org, horms@kernel.org,
fw@strlen.de
Subject: Re: [PATCH net 01/15] ipvs: avoid out-of-bounds write in ip_vs_nat_icmp_v6
Date: Mon, 16 Nov 2026 00:56:57 +0100 [thread overview]
Message-ID: <avpGyYbSJnhlZE0I@chamomile> (raw)
In-Reply-To: <19ba5516-0938-495a-5e7f-57f5fd9a2b45@ssi.bg>
Hi Julian,
On Sat, Nov 14, 2026 at 10:06:38PM +0200, Julian Anastasov wrote:
>
> Hello,
>
> On Sat, 14 Nov 2026, netdev-bot+sashiko@kernel.org wrote:
>
> > Thank you for your contribution! Sashiko AI review found more severe
> > issue(s) in other patches of this series. This mail is only an FYI, in case
> > you want to address the nit picks below when you respin.
>
> In summary: we can drop current patches 1, 2, 15 and
> should address problems in 7.
OK; then I'll drop 1, 2, 7 and 15. Regarding 7, see below.
> We plan to update patch 2 to check for present data.
> Both patches 1 and 2 go together, so they can be dropped for
> now and improved in next version.
>
> Patches 4, 8, 10 and 14 are ok, even if wording can be improved.
>
> Patch 5: we prefer to drop the traffic when port 0 is involved
>
> Patch 7 should be checked by the Netfilter guys.
It seems it is possible to create an expectation on unconfirmed
conntrack entries from the IPVS ftp helper.
For a TCP connection, the conntrack entry should not be already in
confirmed state when the FTP helper runs in most cases.
So I think easiest way is to make a patch to prevent unconfirmed
conntracks from expectations in the IPVS FTP helper.
> Patch 11: NO_CPORT is before connection is established and
> we do not sync conns in master before establishment. So,
> nothing bad can happen in practice.
>
> Patch 12: races are possible but nothing fatal
>
> Patch 15: The patch was meant for ip_vs_bind_xmit_v6. daddr can
> be further limited in next version, so this patch can be dropped.
>
> > --
> > Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113011447.2357709-2-pablo%40netfilter.org
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2026-11-15 23:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 1:14 [PATCH net 00/15] IPVS fixes for net Pablo Neira Ayuso
2026-11-13 1:14 ` [PATCH net 01/15] ipvs: avoid out-of-bounds write in ip_vs_nat_icmp_v6 Pablo Neira Ayuso
2026-11-13 1:16 ` netdev-bot+sinfo
2026-11-13 3:17 ` Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-14 20:06 ` Julian Anastasov
2026-11-15 23:56 ` Pablo Neira Ayuso [this message]
2026-11-13 1:14 ` [PATCH net 02/15] ipv6: update *offset for non-first fragments in ipv6_find_hdr() Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 03/15] ipvs: fix problems during connection deletion Pablo Neira Ayuso
2026-11-13 1:14 ` [PATCH net 04/15] ipvs: avoid stack overflow from recursive connection expiration Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 05/15] ipvs: reject FTP control ports as data ports Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 06/15] ipvs: ftp: skip conntrack templates in ip_vs_ftp_out Pablo Neira Ayuso
2026-11-13 1:14 ` [PATCH net 07/15] ipvs: ftp: add seqadj extension before linking the expectation Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 08/15] ipvs: update flags and seqs in backup server under lock Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 09/15] ipvs: read flags and seqs in master atomically Pablo Neira Ayuso
2026-11-13 1:14 ` [PATCH net 10/15] ipvs: honor the overload state and do not enter it forever Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 11/15] ipvs: validate cport in received sync records Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 12/15] ipvs: skip cport 0 connections in ip_vs_conn_out_get() Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 13/15] ipvs: do not create conns from packets with port 0 Pablo Neira Ayuso
2026-11-13 1:14 ` [PATCH net 14/15] ipvs: wait grace period before reusing destinations Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 1:14 ` [PATCH net 15/15] ipvs: pass correct sk to update_pmtu and on tunneling Pablo Neira Ayuso
2026-11-14 2:15 ` netdev-bot+sashiko
2026-11-13 22:34 ` [PATCH net 00/15] IPVS fixes for net Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avpGyYbSJnhlZE0I@chamomile \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ja@ssi.bg \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox