Netdev List
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: fujita.tomonori@gmail.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	stable@vger.kernel.org, hfdevel@gmx.net
Subject: Re: [PATCH net] net: tn40xx: fix swnode use-after-free on probe failure
Date: Mon, 16 Nov 2026 09:54:15 +0100	[thread overview]
Message-ID: <avrEt3hhG9i5hrd2@hovoldconsulting.com> (raw)
In-Reply-To: <179452098811.2199510.15081106290449010908@kernel.org>

On Thu, Nov 12, 2026 at 10:03:08PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 · Medium: 0 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The patch rests on a wrong premise and adds a refcount leak of
>   the MDIO software node, along with a dangling pointer into freed…

The bot is indeed right. The driver is dropping a reference taken by
another layer and works around a swnode implementation detail.

There would still be a reference imbalance, leading to an early release
of the parent mdio swnode, if mdio bus registration bails out before
taking the reference, but AFAICT that would currently not lead to a UAF
either despite what the comment above
software_node_unregister_node_group() suggests (I'll fix that up
separately).

I'll send a follow up to try to make this less subtle and fragile.

Johan

pw-bot: cr

      parent reply	other threads:[~2026-11-16  8:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 10:00 [PATCH net] net: tn40xx: fix swnode use-after-free on probe failure Johan Hovold
2026-11-10 10:06 ` netdev-bot+sinfo
2026-11-10 10:12   ` Johan Hovold
2026-11-12 22:03 ` netdev-bot+sashiko
2026-11-15 11:47   ` FUJITA Tomonori
2026-11-16  8:54   ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrEt3hhG9i5hrd2@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fujita.tomonori@gmail.com \
    --cc=hfdevel@gmx.net \
    --cc=kuba@kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox