Netdev List
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: John <shffr@protonmail.com>
Cc: "netfilter-devel@vger.kernel.org"
	<netfilter-devel@vger.kernel.org>,
	Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
	"coreteam@netfilter.org" <coreteam@netfilter.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: [REGRESSION] netfilter: flowtable: XMIT_NEIGH flows sent to 00:00:00:00:00:00 once the next hop's neighbour entry is gone
Date: Tue, 17 Nov 2026 02:20:43 +0100	[thread overview]
Message-ID: <avur6_dQVhWTrTTh@chamomile> (raw)
In-Reply-To: <avTngTkNKE5ApQW8@chamomile>

On Wed, Nov 11, 2026 at 11:09:09PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Nov 11, 2026 at 04:21:44PM +0100, Pablo Neira Ayuso wrote:
> > Hi,
> > 
> > Would you give a try to this attached patch?
> 
> I forgot you provided a reproducer, I can see one packet is lost after
> this patch, then the follow up packets don't get blockholed.
> 
> Let me revisit this again.

To address this issue, I think it should be possible to remove the
neighbour lookup from the datapath and let the flowtable GC maintain the
neighbour entry.

https://lore.kernel.org/netfilter-devel/20261117011248.3004853-2-pablo@netfilter.org/T/

If this works, this will allow for more flowtable tx path consolidation
as a follow up.

I lightly tested my patchset with a simple flowtable scenario.

      parent reply	other threads:[~2026-11-17  1:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 21:26 [REGRESSION] netfilter: flowtable: XMIT_NEIGH flows sent to 00:00:00:00:00:00 once the next hop's neighbour entry is gone John
2026-11-11  8:49 ` Thorsten Leemhuis
2026-11-11 15:21 ` Pablo Neira Ayuso
2026-11-11 22:09   ` Pablo Neira Ayuso
2026-11-12  9:08     ` John
2026-11-17  1:20     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avur6_dQVhWTrTTh@chamomile \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=regressions@lists.linux.dev \
    --cc=shffr@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox