From: Florian Westphal <fw@strlen.de>
To: Ma Xinmeng <1564938642@qq.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH nf v2 2/2] selftests: netfilter: test re-owning an already dormant table
Date: Tue, 17 Nov 2026 17:37:19 +0100 [thread overview]
Message-ID: <avyCvycm9Tvdhp60@strlen.de> (raw)
In-Reply-To: <tencent_65062E982D816637E41FE6F24B678214DF09@qq.com>
Ma Xinmeng <1564938642@qq.com> wrote:
> Add a regression test for the nftables table-adoption path. The test
> creates a dormant PERSIST OWNER table, lets the owning nft process exit
> so the table becomes an orphan, adds a basechain while the table is still
> dormant, and re-owns the orphan.
>
> On the buggy tree this calls nf_tables_table_disable() and unregisters a
> hook that was never registered, which triggers WARN_ONCE("hook not
> found") and taints the kernel. The test checks the taint state so it
> fails on the unfixed kernel and passes once the commit path only
> disables a table on a real awake-to-dormant transition.
Would you mind reworking this so we can place it in the nftables.git
shell tests?
tests/shell/testcases/transactions/ would be a good place, I think.
The test would be a bit simpler since nftables run-tests.sh already
does 'tainted kernel' checks, so it only needs the 'add table', 'add
chain', 'add table' sequence.
prev parent reply other threads:[~2026-11-17 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261117161520.1031-1-1564938642@qq.com>
2026-11-17 16:14 ` [PATCH nf v2 1/2] netfilter: nf_tables: only disable tables on a dormant transition Ma Xinmeng
2026-11-17 16:14 ` [PATCH nf v2 2/2] selftests: netfilter: test re-owning an already dormant table Ma Xinmeng
2026-11-17 16:37 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avyCvycm9Tvdhp60@strlen.de \
--to=fw@strlen.de \
--cc=1564938642@qq.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox