Netdev List
 help / color / mirror / Atom feed
From: "Alvin Šipraga" <alvin.sipraga@analog.com>
To: Rustam Adilov <adilov@disroot.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Taiga Ogawa <zectaiga@gmail.com>
Subject: Re: [PATCH net-next] net: dsa: tag_rtl8_4: add support for RTL9607C tag variant
Date: Fri, 20 Nov 2026 13:09:42 +0100	[thread overview]
Message-ID: <awA2z07l0ZvzcWtc@analog.com> (raw)
In-Reply-To: <20261119165129.26693-1-adilov@disroot.org>

On Thu, Nov 19, 2026 at 09:50:51PM +0500, Rustam Adilov wrote:
> The RTL9607C family of SoCs have an embdedded switch that utilizes
> the same Realtek CPU Tag protocol 4 with 8 bytes in size but have
> a bit different of a layout. And that layout is also different for
> TX versus RX sides and introduces new fields not seen by RTL8_4.
> 
> Add basic necessities for this cpu tag variant to function.
> 
> Tested-by: Taiga Ogawa <zectaiga@gmail.com>
> Signed-off-by: Rustam Adilov <adilov@disroot.org>
> ---
> Tested on OpenWrt with 6.18 kernel version [1].

Mainline doesn't have the requisite DSA driver to make use of this
protocol. Andrew, is it normal to accept tag protocol drivers without
the corresponding DSA driver?

I can see that the OpenWRT kernel has a DSA driver using it. Why not
submit that together with this? Otherwise it is kind of dead code IMO.

As a side note, it's unfortunate that Realtek recycles
EtherType/protocol ID values for seemingly different formats. At first I
thought this should be its own file/module, but I can see why you put it
here. My one concern would be whether the semantics for the common
fields are actually the same for both protocols? If not then maybe it's
better to separate them after all to avoid confusion.

> 
> The RTL8_4AP name was mostly chosen because Realtek gave the RTL9607C
> family of SoCs a codename "ApolloPro" in their SDK, hence "AP" part.
> Originally it was named RTL8_4_RTL9607C but that feels weird.
> 
> [1] https://github.com/openwrt/openwrt/pull/26496
> ---
>  include/net/dsa.h    |   2 +
>  net/dsa/tag_rtl8_4.c | 193 ++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 194 insertions(+), 1 deletion(-)

Kind regards,
Alvin

      reply	other threads:[~2026-11-20 12:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 16:50 [PATCH net-next] net: dsa: tag_rtl8_4: add support for RTL9607C tag variant Rustam Adilov
2026-11-20 12:09 ` Alvin Šipraga [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awA2z07l0ZvzcWtc@analog.com \
    --to=alvin.sipraga@analog.com \
    --cc=adilov@disroot.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=zectaiga@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox