From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795362853; b=khEKYvhBLUAc29mBshNviZ3x54tTULDPd0u/B0fQEQ5gv9An2ZARS/IUqlb8mFvGSn66 GdDa2N5Hmhrhh9FC3mvlFO6GAwW276xvzB/uqUcpEviEU7x13hfNBq8H8pM5wsw/W7brA Pfkxnz7FYubaZjmQOvCtsd2MYRj1v36CKFPr/AWnGsr4iJO8lV21ZhEFfKtbOkzCcpkWR z++DR3ZKUpe8lu/3WNCzgayh5eO/IZP1D3Ow3A5Htso+MJ1SDrLzFO5vwNbDFv3jhxEJ8 Zk1/8SmFAQy+F1bmVHluawu6xo9Xb47N6SVNohuhjNCBZDXEeB+oDilh1n8/tMX8/Ow== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795362853; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=oAH/5Ektz81ojOZdHN4K4NLybO43vkB7oJL3F3Dgs+c=; b=VqO4wnCronfYkGq7fVpfOmIWOyp56dkg8jldwHVV9vwEZX0foq9m2Yc6IZe7slu18nl4 SpNup4R6JHqK236N5hGFYF9hbbQDVC/vWmrq38qIbdgPD9Xm66QcU1PKfM/iZubS4pVFt r98rp5VR8rYz9U0PzJ9LYEw+tbjnRVwm9VeW4wFb6fn57FBA/B3ninL1SesoWWLrVQAOW Oof/lp8UDrHQGXiAbBqDdVRmm5skU/hl8jD9ZtEmoz6mHBFIYRx4dCL0HuXUC/fNICHKE QhQXqrAsxMeq2mY6IRjf9LNmg6qJO9UWPbsF0QAINH+hj1Q0smhFP+IZ2kJXzhI71tw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=resnulli.us; spf=pass smtp.mailfrom=resnulli.us; dkim=pass header.d=resnulli.us header.i=@resnulli.us header.a=rsa-sha256 header.s=google header.b=LFzAgprE; arc=none smtp.remote-ip=209.85.221.43 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F124B606A320 for ; Sun, 22 Nov 2026 15:54:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F124B606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli.us header.i=@resnulli.us header.a=rsa-sha256 header.s=google header.b=LFzAgprE Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4a9be758734so1449712f8f.1 for ; Sun, 22 Nov 2026 07:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli.us; s=google; t=1795362850; x=1795967650; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=oAH/5Ektz81ojOZdHN4K4NLybO43vkB7oJL3F3Dgs+c=; b=LFzAgprEXvV7qN0PQPj7ld69lD/xcWYp4wpu3Y9tNDc7EmwuE8oE382/mwCFKL3Acx 3ZNQ5KrRc20+JObyi2/7Ryuo3LdqqQCS1DrXMwy/VU82dQiablkt7wUoQyV2lDwtDG8q kxWJaq0a8ZrO3HepNPwmBJePlMvULyld6DxFAE7lxr4O8YmM/XkH95Yll53iRIaD9/kn ASd9WBeqet6CwARCTt9ChvSNv/T/7iapK6Fy/EMLRj/OTiaso+GsZZ0S0i05GJHflgkB vVLjtuXq3L7G74hIDXCxjEK/zrldn9noodIgVxstZMEwI9jUEohc3nCOiCTQDwyatjgx liuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795362850; x=1795967650; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=oAH/5Ektz81ojOZdHN4K4NLybO43vkB7oJL3F3Dgs+c=; b=mbIaWFmBhGCntOhsKbUAViCS8efAlvCBtPDDyK1+3Yu9rAMasWl4cGO1O9XGTFy+P0 pRugIujYl2diVbfkqaevINoTx47SfOjHUTW9ESaZEolNbwXd/vCvAcwDFy7bMS1AUWGT 99Jy8NAmIF+LSLkUgWvSdEUB6ozqTPmjNQZ5gwMbEMWfZ4pbNzP82PeYw8Jzd1ZjLH1x rMnH3pGv23G2umsVqNn01AtRiA+wZfeopwPo6Qgm00ewCcU5ElYdzIgbKIBfdW3sdvs8 VuhhXD/RQYJpxvP6u5b9M/7m2jCZ98Y79JP7tpo317yhYE5cUa2xl007irRaAlmpmsrQ ywNw== X-Forwarded-Encrypted: i=1; AL+hErFzaH0ZGJZTMe7R0M/BKk9EEH5d8GAPysSfYDa1DAioIJ3EGkBerFi1bfOvaq4JEzIQ+rvYpy8=@vger.kernel.org X-Gm-Message-State: APuU4Z+ld8hI37pSzVymJMyVFgz/akN/nQbkGd/nejCQhTttZEPjN0yh aj6UFjm4RwEIjlmou9cMK8jdn5WaL/S3rZy91M6qJXQUapRfT20e4U3VIHLbc4iRdec= X-Gm-Gg: AZFdTZfYZTG8IaAxlbb9XBCrZrcOKKm2x2KTeOSvidbHrjva2DLdP943d8jNN2dmt3N 5CXk+tZSZqEzVcqqWKG4Me3cdazcsRYdasv0S9zMp8BYiVhgOu70BedCUNT76Q6QxclXyLvGAdp mout5kBcw8qotMAMNQLhVN+B8/TZpPxSICkM8mdugAzMwzQBvzPVDpckw9Aidq6YovADXwTqCkO ESJ0a+Q+VPEFfYfN0fEX54bVaS6B46QKfcwpwWkj4O7BKZtMApDRf3S7AC1gnV7EyuJ6mE1G8LX A9CdliCgA40LHrcoLwZKcB93XOTkWZZi7bqNVO++BTL/x+HOerJ7qF2snzA+F4XenVlWR0g9CuQ xwMXc2N6WuZiF+0FlAaXmLc+W10pVuWzx+yUBBuQXQM9dJY9Xp6WFCezwZ7uNPMfGla2zmdZB03 J28SbV+iYCUYzShWQ+e9vwHhzU2gr02jctuuypN85WMpOgixdgRoGGHsmdQdHDj7XsCrKPq976K rAGNpgY7A3Vo++quW80WhwcGkZDk3rniDi/r8TrGo5iCVTNj8giNbvtkCNawBhG5BjfXLRVRV/Y jI5w5+jG79ta1AkIrHf21mp705rhIufGx6cGhw== X-Received: by 2002:a5d:64c9:0:b0:4a7:69c3:94d5 with SMTP id ffacd0b85a97d-4abb0e469cfmr16973589f8f.28.1795362850015; Sun, 22 Nov 2026 07:54:10 -0800 (PST) Received: from localhost ([128.77.52.126]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab69bf61e8sm18394509f8f.11.2026.11.22.07.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2026 07:54:09 -0800 (PST) Date: Sun, 22 Nov 2026 16:54:05 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Ivan Vecera , Jakub Kicinski , Arkadiusz Kubalewski , netdev@vger.kernel.org, Jonathan Corbet , Shuah Khan , Randy Dunlap , Min Li , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Grzegorz Nitka , Karol Kolacinski , Saeed Mahameed , Tariq Toukan , Petr Oros Subject: Re: [PATCH net-next v2 0/9] dpll: do not serialize driver callbacks under global dpll_lock Message-ID: References: <20261111164021.273409-1-ivecera@redhat.com> <20261116181612.107a4b57@kernel.org> <20261118174424.32e9f130@kernel.org> <20261119133851.3f25074c@kernel.org> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Fri, Nov 20, 2026 at 09:00:27PM +0100, vadim.fedorenko@linux.dev wrote: >On 20/11/2026 07:39, Ivan Vecera wrote: >> On 11/19/26 22:38, Jakub Kicinski wrote: >> > Well, I'm not convinced. The relations between objects in DPLL are >> > already quite hard to follow, and objects from one driver routinely >> > "plug" into objects from another. The explanation of the locking >> > rules in patch 9 does not look clean or clear. The driver facing >> > API needs to be much more "dummy-proof". >> >> Fair enough. The complicated part of the rules comes exactly from >> that: a pin registered by another driver, like the zl3073x pins that >> ice registers with its TXC DPLL or uses as parents of its RCLK pins. >> A message about such a pin runs callbacks of both drivers. I have >> prototypes of the first four ways below to lock this, each with KUnit >> tests, and would like your opinion before going further. >> >> In all of them a domain is the set of objects created with the same >> module and clock_id, dpll_lock becomes an rwsem for the topology and >> lifetime, and a mutex per domain serializes the callbacks. >> >> A) Pin's domain (this series) >> >>    Callbacks of a pin run under the domain of the pin, whichever >>    driver registered them. >> >>    Pros: >>    * one domain lock at a time, so no lock order >>    * a request or a message about a pin is atomic >>    Cons: >>    * the callbacks of a foreign pin are serialized with the driver >>      that created the pin, not with the other callbacks of the driver >>      that registered it, so that driver has to protect the shared >>      state itself, and lockdep cannot check it >>    * restrictions for measured_freq_get, reference sync pairs and the >>      private data of a parent pin, which patch 9 has to explain >> >> B) Registrant's domain, deferred notifications >> >>    Each callback runs under the domain of the driver that registered >>    it. A message about a pin takes the domain locks one after another, >>    and notifications from callbacks are queued and sent once the >>    domain lock is dropped. >> >>    Pros: >>    * callbacks registered by one driver instance are always >>      serialized with each other >>    * one domain lock at a time, so no lock order >>    Cons: >>    * a request or a message about a pin registered across domains is >>      not atomic >>    * the most complex core: a notification queue per domain, a lock >>      per object to keep its messages in order, and pin setters split >>      into validation and apply parts >> >> C) Registrant's domain nested under the pin's domain >> >>    Pros: >>    * callbacks registered by one driver instance are serialized with >>      each other and with the driver that created the pin >>    * a request or a message about a pin is atomic >>    Cons: >>    * the lock order comes from the topology, so a pin of A registered >>      with a DPLL of B together with a pin of B registered with a DPLL >>      of A deadlocks, and lockdep sees it only with a lockdep class per >>      domain >>    * a stuck foreign registrant stops the domain of the pin >> >> D) Merged domains (your suggestion) >> >>    Registering a pin with a DPLL or a parent pin of another domain >>    merges both domains. They are not split again. >> >>    Pros: >>    * the rules for drivers stay as they are with the global lock >>      today, and lockdep checks them; the only new one is that state >>      shared between chips not connected by a pin needs a driver lock >>    * a request or a message is atomic >>    Cons: >>    * only hardware not connected by pins runs in parallel; on the >>      GNR-D system the zl3073x and all ice PFs end up in one domain >>    * a callback that waits for the hardware, like the planned resync >>      for up to 1 s, or for firmware still stalls all DPLL devices in >>      the merged domain >> >> E) Global dpll_lock, slow callbacks asynchronous >> >>    Pros: >>    * no change in the core >>    Cons: >>    * the resync problems from my previous mail, and a callback that >>      waits for firmware still stalls all DPLL devices in the system >> >> I wrote before that stretching the domains would not improve >> anything on that system. That holds for the ToD stall I measured, >> but the zl3073x does not need to hold its channel lock across the >> edge waits. Without that, the remaining waits are the planned resync >> and output state callbacks, and with D they stall only the devices >> wired to that chip, which depend on it anyway. >> >> So I lean towards D, as it gives drivers nothing new to get right. >> Would that address your concern, or do you see a better way? >> >> It would be good to hear from the other DPLL maintainers as well. >> Jiri, Vadim, Arkadiusz, what do you think? > >I totally agree with Jakub. Current implementation of DPLL subsystem is >over complicated, and all these complications came just to completely >model what was designed for Intel NICs, basically ice driver. But now we >are again back to the discussion how to complicate things further just >to fit what was implemented in the new generation of the same hardware. > >Maybe it's time to step back and think if we really need all this, or >find simpler way to express/model things? Agreed.