From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E1A0C43334 for ; Thu, 9 Jun 2022 11:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244534AbiFILuF (ORCPT ); Thu, 9 Jun 2022 07:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244663AbiFILuC (ORCPT ); Thu, 9 Jun 2022 07:50:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 00FA620A722 for ; Thu, 9 Jun 2022 04:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654775396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DuwhD3TtwqmPc3FtJmMtruEqS+FysyJ1M2ttopTd4UE=; b=QXRwcZKUWlYp26MQSQFUIAlm65ZDBXdmXrWsmaS5F2jHuaUT47L/BKxBoJQUr41ngcOUZM Um0Cnof/UJpstY+ynQi+cVLYrOFSHOAf+w0b2k8GEpDCJWbh5SsU0wATWMlh7XatWTcybt s+fFlDtEIowMKHBHPuB3p371xf6uoYw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-88-rmUpZjWePUiwSj9o6svA4w-1; Thu, 09 Jun 2022 07:49:55 -0400 X-MC-Unique: rmUpZjWePUiwSj9o6svA4w-1 Received: by mail-qt1-f198.google.com with SMTP id t35-20020a05622a182300b00305099b873bso2261667qtc.18 for ; Thu, 09 Jun 2022 04:49:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=DuwhD3TtwqmPc3FtJmMtruEqS+FysyJ1M2ttopTd4UE=; b=4JT92/gQX//8uuH9v7klm5kRUOXk2KeIlXcGjhhiG+nT1Ux/KxnD/9zRZi/KM4kikl O+dchKziq7P71ktRQdhOIT2PzLSfyMSTQ6mHdOQZfat39UUfLjb4eFJ+gqa9SNnmi0uh 7A1ufwWG5TQ1xNsFdIyQc4de5NsQIczNWWzjru3Nd0/OACBV7txkgV1GpQWOqYvh/t0b x/cdYG0FzplOHE2HpF+cNonY++vKaF3al/UlksmrIEyab4mVrFNMNfZzZpxr6ywMmgDS GZgAmYLpnrRRGfJbyh9zRu1YIKvZIM9hhusa1MCB1FF/df77GfY4dUx7qUCCouZIPdhV 2ltg== X-Gm-Message-State: AOAM532OiyG6LVLy+o/L8MsKKXc3+zcBjiTV0Qml9t31hf6Oajn+OgpX gPz7/J4+qQWg3EZpL2cYxj3XwGUH8UUbD/c3qpTel7vDuXlxQJBEpq/JHDmRHH87qSzALETk3vg cKIiBr2HYR1hJ4Vv7 X-Received: by 2002:a05:6214:761:b0:441:196:795e with SMTP id f1-20020a056214076100b004410196795emr83996400qvz.67.1654775395351; Thu, 09 Jun 2022 04:49:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiM6WZ7qFmx0s6PGdh/jWpyxlZoyVwejHGOyF0aVfaLqcBlYDNDG9DqxVM31JDDGzdiHNvxg== X-Received: by 2002:a05:6214:761:b0:441:196:795e with SMTP id f1-20020a056214076100b004410196795emr83996374qvz.67.1654775395085; Thu, 09 Jun 2022 04:49:55 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-113-202.dyn.eolo.it. [146.241.113.202]) by smtp.gmail.com with ESMTPSA id i21-20020a05620a405500b006a6ac4e7ab4sm12759648qko.112.2022.06.09.04.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jun 2022 04:49:54 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next] net: rename reference+tracking helpers From: Paolo Abeni To: Eric Dumazet , David Ahern Cc: Jakub Kicinski , Jiri Pirko , David Miller , netdev , Steffen Klassert , jreuter@yaina.de, razor@blackwall.org, Karsten Graul , ivecera@redhat.com, Jon Maloy , Ying Xue , Xin Long , Arnd Bergmann , Yajun Deng , Antoine Tenart , richardsonnick@google.com, Heiner Kallweit , linux-hams@vger.kernel.org, dev@openvswitch.org, linux-s390@vger.kernel.org, tipc-discussion@lists.sourceforge.net Date: Thu, 09 Jun 2022 13:49:48 +0200 In-Reply-To: References: <20220608043955.919359-1-kuba@kernel.org> <20220608075827.2af7a35f@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2022-06-08 at 16:00 -0700, Eric Dumazet wrote: > On Wed, Jun 8, 2022 at 3:58 PM David Ahern wrote: > > > > On 6/8/22 8:58 AM, Jakub Kicinski wrote: > > > IMO to encourage use of the track-capable API we could keep their names > > > short and call the legacy functions __netdev_hold() as I mentioned or > > > maybe netdev_hold_notrack(). > > > > I like that option. Similar to the old nla_parse functions that were > > renamed with _deprecated - makes it easier to catch new uses. > > I think we need to clearly document the needed conversions for future > bugfix backports. > To be on the same page: do you think we need something under Documentation with this patch? or with the later dev_hold rename? or did I misunderstood completely? Thanks! Paolo