From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports Date: Thu, 25 Oct 2018 18:08:06 -0400 Message-ID: References: <20181025210227.25544-1-3chas3@gmail.com> <20181025211008.GA2229@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org To: Jiri Pirko Return-path: Received: from mail-qt1-f194.google.com ([209.85.160.194]:46687 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726373AbeJZGme (ORCPT ); Fri, 26 Oct 2018 02:42:34 -0400 Received: by mail-qt1-f194.google.com with SMTP id c16-v6so11805484qtj.13 for ; Thu, 25 Oct 2018 15:08:08 -0700 (PDT) In-Reply-To: <20181025211008.GA2229@nanopsycho.orion> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/25/2018 05:10 PM, Jiri Pirko wrote: > Thu, Oct 25, 2018 at 11:02:27PM CEST, 3chas3@gmail.com wrote: >> netif_is_lag_port should be used to identify link aggregation ports. >> For this to work, we need to reorganize the bonding and team drivers >> so that the necessary flags are set before dev_open is called. >> >> commit 31e77c93e432 ("sched/fair: Update blocked load when newly idle") >> made this decision originally based on the IFF_SLAVE flag which isn't >> used by the team driver. Note, we do need to retain the IFF_SLAVE >> check for the eql driver. >> >> Signed-off-by: Chas Williams <3chas3@gmail.com> >> --- >> drivers/net/bonding/bond_main.c | 4 ++-- >> drivers/net/team/team.c | 7 +++++-- >> net/ipv6/addrconf.c | 2 +- > > Subject talks about "team" yet you modify bond and team. Confusing.. The subject discusses what I want to do. The body of the message covers how I had to do it. The behavior of bonding with respect to addrconf isn't changed but netif_is_lag_port is picky about the flags it wants to see from bonding. So some bonding changes are necessary.