* [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt
@ 2017-02-01 21:05 Heiner Kallweit
2017-02-02 2:20 ` Phil Reid
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2017-02-01 21:05 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org
I can only imagine that this message ended up there by a copy & paste
mistake. The same message appears correctly a few lines later, but
here it doesn't make sense.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 460f94f5..5edf23dc 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -371,7 +371,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
} else {
clk_prepare_enable(plat->clk_ptp_ref);
plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
- dev_info(&pdev->dev, "No reset control found\n");
}
plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt
2017-02-01 21:05 [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt Heiner Kallweit
@ 2017-02-02 2:20 ` Phil Reid
2017-02-02 7:18 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Phil Reid @ 2017-02-02 2:20 UTC (permalink / raw)
To: Heiner Kallweit, David Miller; +Cc: netdev@vger.kernel.org
On 2/02/2017 05:05, Heiner Kallweit wrote:
> I can only imagine that this message ended up there by a copy & paste
> mistake. The same message appears correctly a few lines later, but
> here it doesn't make sense.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 460f94f5..5edf23dc 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -371,7 +371,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
> } else {
> clk_prepare_enable(plat->clk_ptp_ref);
> plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
> - dev_info(&pdev->dev, "No reset control found\n");
> }
>
> plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
>
It was originally:
netdev_dbg(priv->dev, "PTP rate %d\n", priv->clk_ptp_rate);
Before it got moved in:
commit f573c0b9c4e02691cf87736bd0824fd37ec02e65
stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure
--
Regards
Phil Reid
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt
2017-02-02 2:20 ` Phil Reid
@ 2017-02-02 7:18 ` Heiner Kallweit
0 siblings, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2017-02-02 7:18 UTC (permalink / raw)
To: Phil Reid, David Miller; +Cc: netdev@vger.kernel.org
Am 02.02.2017 um 03:20 schrieb Phil Reid:
> On 2/02/2017 05:05, Heiner Kallweit wrote:
>> I can only imagine that this message ended up there by a copy & paste
>> mistake. The same message appears correctly a few lines later, but
>> here it doesn't make sense.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index 460f94f5..5edf23dc 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -371,7 +371,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>> } else {
>> clk_prepare_enable(plat->clk_ptp_ref);
>> plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
>> - dev_info(&pdev->dev, "No reset control found\n");
>> }
>>
>> plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
>>
>
> It was originally:
> netdev_dbg(priv->dev, "PTP rate %d\n", priv->clk_ptp_rate);
> Before it got moved in:
> commit f573c0b9c4e02691cf87736bd0824fd37ec02e65
> stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure
>
Thanks for the hint, I'll send a v2 to restore the original message.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-02 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01 21:05 [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt Heiner Kallweit
2017-02-02 2:20 ` Phil Reid
2017-02-02 7:18 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).