netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: soukjin.bae@samsung.com,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: (2) (2) [Kernel][NET] Bug report on packet defragmenting
Date: Wed, 7 Nov 2018 22:13:37 -0800	[thread overview]
Message-ID: <b03af88f-8f18-bdac-ae64-c3c0688008d3@gmail.com> (raw)
In-Reply-To: <8b2209af-1221-f4f5-54e5-d9f5a503373e@gmail.com>



On 11/07/2018 08:26 PM, Eric Dumazet wrote:
> 
> 
> On 11/07/2018 08:10 PM, 배석진 wrote:
>>> --------- Original Message ---------
>>> Sender : Eric Dumazet <eric.dumazet@gmail.com>
>>> Date   : 2018-11-08 12:57 (GMT+9)
>>> Title  : Re: (2) [Kernel][NET] Bug report on packet defragmenting
>>>  
>>> On 11/07/2018 07:24 PM, Eric Dumazet wrote:
>>>
>>>>  Sure, it is better if RPS is smarter, but if there is a bug in IPv6 defrag unit
>>>>  we must investigate and root-cause it.
>>>  
>>> BTW, IPv4 defrag seems to have the same issue.
>>  
>>
>> yes, it could be.
>> key point isn't limitted to ipv6.
>>
>> maybe because of faster air-network and modem,
>> it looks like occure more often and we got recognized that.
>>
>> anyway,
>> we'll apply our patch to resolve this problem.
> 
> Yeah, and I will fix the defrag units.
> 
> We can not rely on other layers doing proper no-reorder logic for us.
> 
> Problem here is that multiple cpus attempt concurrent rhashtable_insert_fast()
> and do not properly recover in case -EEXIST is returned.
> 
> This is silly, of course :/

Patch would be https://patchwork.ozlabs.org/patch/994658/

  reply	other threads:[~2018-11-08 15:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181108012927epcms1p47f719c1908da64a378690362901644ee@epcms1p4>
2018-11-08  1:29 ` [Kernel][NET] Bug report on packet defragmenting 배석진
2018-11-08  1:43   ` Eric Dumazet
     [not found]   ` <CGME20181108012927epcms1p47f719c1908da64a378690362901644ee@epcms1p5>
2018-11-08  2:05     ` 배석진
2018-11-08  3:24       ` (2) " Eric Dumazet
2018-11-08  3:56         ` Eric Dumazet
     [not found]         ` <CGME20181108012927epcms1p47f719c1908da64a378690362901644ee@epcms1p6>
2018-11-08  4:10           ` 배석진
2018-11-08  4:26             ` (2) " Eric Dumazet
2018-11-08  6:13               ` Eric Dumazet [this message]
     [not found]               ` <CGME20181108012927epcms1p47f719c1908da64a378690362901644ee@epcms1p2>
2018-11-08  7:58                 ` 배석진
2018-11-08 15:12                   ` (2) " Eric Dumazet
     [not found]                   ` <CGME20181108012927epcms1p47f719c1908da64a378690362901644ee@epcms1p1>
2018-11-09  0:42                     ` 배석진
2018-11-09  1:58                       ` (2) " Eric Dumazet
2018-11-09  2:24                 ` 배석진

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b03af88f-8f18-bdac-ae64-c3c0688008d3@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=soukjin.bae@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).