From: "Miguel Ángel Álvarez" <gotzoncabanes@gmail.com>
To: netdev@vger.kernel.org, "Krzysztof Halasa" <khc@pm.waw.pl>
Subject: [PATCH 1/1] ixp4xx_hss: Non-used lut variable
Date: Mon, 24 Nov 2008 15:37:42 +0100 [thread overview]
Message-ID: <b0438a630811240637i3636b297taafa01f4947a4b1c@mail.gmail.com> (raw)
Hi.
Taking a look to ixp4xx_hss code, I have found a non-used variable in
hss_config_set_lut. I suppose it is part of a deprecated code. This
patch removes it.
Signed-off-by: Miguel Ángel Álvarez (gotzoncabanes@gmail.com)
---
diff -urN linux-2.6.26.7_hssorig/drivers/net/wan/ixp4xx_hss.c
linux-2.6.26.7_hsspatched/drivers/net/wan/ixp4xx_hss.c
--- linux-2.6.26.7_hssorig/drivers/net/wan/ixp4xx_hss.c 2008-11-24
15:29:27.000000000 +0100
+++ linux-2.6.26.7_hsspatched/drivers/net/wan/ixp4xx_hss.c 2008-11-24
15:33:55.000000000 +0100
@@ -521,9 +521,7 @@
{
struct msg msg;
int chan_count = 0, log_chan = 0, i, ch;
- u32 lut[MAX_CHANNELS / 4];
-
- memset(lut, 0, sizeof(lut));
+
for (i = 0; i < MAX_CHAN_DEVICES; i++)
if (port->chan_devices[i])
port->chan_devices[i]->chan_count = 0;
Thanks
Miguel Ángel Álvarez
next reply other threads:[~2008-11-24 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 14:37 Miguel Ángel Álvarez [this message]
2008-11-24 16:36 ` [PATCH 1/1] ixp4xx_hss: Non-used lut variable Krzysztof Halasa
2008-11-24 17:13 ` Miguel Ángel Álvarez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0438a630811240637i3636b297taafa01f4947a4b1c@mail.gmail.com \
--to=gotzoncabanes@gmail.com \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox