From: "Miguel Ángel Álvarez" <gotzoncabanes@gmail.com>
To: netdev@vger.kernel.org, "Krzysztof Halasa" <khc@pm.waw.pl>
Subject: ixp4xx_hss. Little bug in hss_init_one
Date: Wed, 26 Nov 2008 18:13:06 +0100 [thread overview]
Message-ID: <b0438a630811260913t638343a4i5576292b367c5dc2@mail.gmail.com> (raw)
Hi
I have found that platform_set_drvdata is not correctly called if we
have an error in requesting npe. Am I right?
Signed-off-by: Miguel Ángel Álvarez (gotzoncabanes@gmail.com)
---
--- ixp4xx_hss.c.orig 2008-11-19 11:26:54.000000000 +0100
+++ ixp4xx_hss.c.initone 2008-11-26 18:09:22.000000000 +0100
@@ -2698,8 +2698,8 @@
free_netdev(dev);
err_plat:
npe_release(port->npe);
- platform_set_drvdata(pdev, NULL);
err_free:
+ platform_set_drvdata(pdev, NULL);
kfree(port);
return err;
}
Thanks
Miguel Ángel Álvarez
next reply other threads:[~2008-11-26 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 17:13 Miguel Ángel Álvarez [this message]
2008-12-04 20:32 ` ixp4xx_hss. Little bug in hss_init_one Krzysztof Halasa
2008-12-05 7:56 ` Miguel Ángel Álvarez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0438a630811260913t638343a4i5576292b367c5dc2@mail.gmail.com \
--to=gotzoncabanes@gmail.com \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox