From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next,v3 03/12] flow_dissector: add flow action infrastructure Date: Wed, 21 Nov 2018 20:47:41 -0800 Message-ID: References: <20181121025132.14305-1-pablo@netfilter.org> <20181121025132.14305-4-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, thomas.lendacky@amd.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com To: Pablo Neira Ayuso , netdev@vger.kernel.org Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:42496 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388948AbeKVPZb (ORCPT ); Thu, 22 Nov 2018 10:25:31 -0500 Received: by mail-pl1-f193.google.com with SMTP id x21-v6so8590904pln.9 for ; Wed, 21 Nov 2018 20:47:55 -0800 (PST) In-Reply-To: <20181121025132.14305-4-pablo@netfilter.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/20/2018 6:51 PM, Pablo Neira Ayuso wrote: > This new infrastructure defines the nic actions that you can perform > from existing network drivers. This infrastructure allows us to avoid a > direct dependency with the native software TC action representation. > > Signed-off-by: Pablo Neira Ayuso > --- [snip] > +#define flow_action_for_each(__i, __act, __actions) \ > + for (__i = 0, __act = &(__actions)->entries[0]; __i < (__actions)->num_entries; __act = &(__actions)->entries[++__i]) Post increment is more common in for_each* constructs, any reason why you are you using a pre increment here? -- Florian