From: Andrew Lunn <andrew@lunn.ch>
To: Prashant Sengar <prashantsengar25031@gmail.com>
Cc: netdev@vger.kernel.org, Thangaraj.S@microchip.com,
UNGLinuxDriver@microchip.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH net] net: usb: lan78xx: avoid NULL PHY dereference in WoL setup
Date: Sun, 18 Oct 2026 18:21:34 +0200 [thread overview]
Message-ID: <b050adae-97b7-4f9a-93cc-5f2f96bf6e3e@lunn.ch> (raw)
In-Reply-To: <20261018151830.643511-1-prashantsengar25031@gmail.com>
On Sun, Oct 18, 2026 at 08:48:30PM +0530, Prashant Sengar wrote:
> LAN7801 supports fixed-link configurations without an attached PHY.
> However, lan78xx_set_wol() unconditionally passes netdev->phydev
> to phy_ethtool_set_wol(), which dereferences the missing PHY.
>
> Only call the PHY Wake-on-LAN helper when a PHY is attached.
A MAC driver using phylink_ should not call any phy_ methods
directly. It should always go via the phylink API.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-10-18 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 15:18 [PATCH net] net: usb: lan78xx: avoid NULL PHY dereference in WoL setup Prashant Sengar
2026-10-18 16:21 ` Andrew Lunn [this message]
2026-10-19 15:20 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b050adae-97b7-4f9a-93cc-5f2f96bf6e3e@lunn.ch \
--to=andrew@lunn.ch \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prashantsengar25031@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox