From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D1B1F924 for ; Wed, 13 Sep 2023 15:52:11 +0000 (UTC) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 593DD19BF; Wed, 13 Sep 2023 08:52:11 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bc0d39b52cso53463495ad.2; Wed, 13 Sep 2023 08:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694620331; x=1695225131; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dvjLZ7w4l2TGPbXRRO5tl0m6HCbt4GkrFMBas1aFYsE=; b=eS8VJKeU3FrovB6o0Y8VYDdGraA5tJCQ+9kT2Xek4AwAjctq5d/earNN7E3GhrFlHN Gwc7/Yq1aaPAKco5pIRpX4prSB3gJGad0/L9wxSZgKMrUrq+HZUDakx7jaRYDezIusOX AWxZ0p6+4CJvY3KgvniVS6kBSWE9cVA0jGuRNcl50rZClzMKJjty8FhcdKm/lvzGCRoF mBf6x+fbVPo1wi+/5PBgtZscb0T6YDtjzX3Cv/g2mIQc3FwzmngCY1XxHM7htZHvTM4d Ca2gg9iFrLD7vs0ocFKBLtiYlNPYzvIS50e5odyM7AulnrgqJobqYfFO0Vdq1T4cYk6+ AKVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694620331; x=1695225131; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dvjLZ7w4l2TGPbXRRO5tl0m6HCbt4GkrFMBas1aFYsE=; b=FW096cbQLyTgVTOfjlf9mlWgsG4q4307GfAQBnzf2CK3NzmhT5OEvqJOkIZh4MjYJi D8sTr1ERJE3NYWN7iVmBcATmMHE+frA3ltOoiwxomcVQD34ChzhQ7VLqjKU4Em2S4sQM mAKrvq5dvK8pcB+PBgkjmnTtYVJr9QExXe0HWZ197zkq036yffFSl9Bl6nrHRmHhukmp tF+RV576PvoG6izGw0oD6gZFisAmMkBvjRKSr1th4dktgYvHawQU3frfh7MphaJ/H8uh BxFu4m07mny9BFmmsU44kkClq5l6dvkbvRf/YL4Ard/ijgIDHNC/0pwFAS+dedyV/kFm 6AjQ== X-Gm-Message-State: AOJu0YyF7mUBkc9hVn/zgmP5Sgbr/irh2SeZGe4bRavQQneAIad0Zh4q 6Zx+/ZOG00ru5xk2V1Phq/QIxrSx+8k= X-Google-Smtp-Source: AGHT+IF6fVWdKQ0UKoigMg6gUgilNC9ab3/1AfMPR67DZP3zVAtX//hc6B1mpDbrWpFWcj48YVWWCg== X-Received: by 2002:a17:902:d491:b0:1b8:76ce:9dab with SMTP id c17-20020a170902d49100b001b876ce9dabmr3513070plg.41.1694620330609; Wed, 13 Sep 2023 08:52:10 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id o3-20020a170902bcc300b001b801044466sm10609186pls.114.2023.09.13.08.52.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Sep 2023 08:52:09 -0700 (PDT) Message-ID: Date: Wed, 13 Sep 2023 08:52:08 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: dsa: rtl8366rb: Implement setting up link on CPU port Content-Language: en-US To: Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230912-rtl8366rb-link-v1-1-216eed63f357@linaro.org> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <20230912-rtl8366rb-link-v1-1-216eed63f357@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/12/2023 2:24 PM, Linus Walleij wrote: > We auto-negotiate most ports in the RTL8366RB driver, but > the CPU port is hard-coded to 1Gbit, full duplex, tx and > rx pause. > > This isn't very nice. People may configure speed and > duplex differently in the device tree. > > Actually respect the arguments passed to the function for > the CPU port, which get passed properly after Russell's > patch "net: dsa: realtek: add phylink_get_caps implementation" > > After this the link is still set up properly. > > Signed-off-by: Linus Walleij Reviewed-by: Florian Fainelli -- Florian