From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013D1C3F2D1 for ; Mon, 2 Mar 2020 16:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D461924673 for ; Mon, 2 Mar 2020 16:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727195AbgCBQHy (ORCPT ); Mon, 2 Mar 2020 11:07:54 -0500 Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:39018 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbgCBQHx (ORCPT ); Mon, 2 Mar 2020 11:07:53 -0500 X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4CD13140073; Mon, 2 Mar 2020 16:07:51 +0000 (UTC) Received: from [10.17.20.203] (10.17.20.203) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 2 Mar 2020 16:07:40 +0000 Subject: Re: [patch net-next 00/10] net: allow user specify TC filter HW stats type To: Jiri Pirko , Pablo Neira Ayuso CC: Jamal Hadi Salim , Jakub Kicinski , , , , , , , , , , , , , , Marian Pritsak References: <20200221095643.6642-1-jiri@resnulli.us> <20200221102200.1978e10e@kicinski-fedora-PC1C0HJN> <20200222063829.GB2228@nanopsycho> <20200224131101.GC16270@nanopsycho> <9cd1e555-6253-1856-f21d-43323eb77788@mojatatu.com> <20200224162521.GE16270@nanopsycho> <20200225162203.GE17869@nanopsycho> <20200228195909.dfdhifnjy4cescic@salvia> <20200229080120.GP26061@nanopsycho> From: Edward Cree Message-ID: Date: Mon, 2 Mar 2020 16:07:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200229080120.GP26061@nanopsycho> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [10.17.20.203] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25264.003 X-TM-AS-Result: No-7.126200-8.000000-10 X-TMASE-MatchedRID: nVQUmLJJeybmLzc6AOD8DfHkpkyUphL96y7Z+mBhUl0Tvdh6VFADyc9x vC1/5d4Z84NB8AEyFvr9LeU/rVo3pZTUoGfImkdk/ccgt/EtX/1Dmn7kzuSuKdfVxEPp7g/kR5T vx+kKh7CSmxTZw6MyoVDfyYbqflqTOJQuSr/cFG7rOLyP6vXu3X0tCKdnhB58ZYJ9vPJ1vSDUCj MSsLl1x+TCMddcL/gjsjvNV98mpPNjCeJDJ8IVkNrikcC6stYqQ0TGvc9gYoM7Q9p2gghMsS12k o7AvGvNftwZ3X11IV0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.126200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25264.003 X-MDID: 1583165272-nJLE198ELXn9 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 29/02/2020 08:01, Jiri Pirko wrote: > Fri, Feb 28, 2020 at 08:59:09PM CET, pablo@netfilter.org wrote: >> Something like the sketch patch that I'm attaching? > But why? Actions are separate entities, with separate counters. The > driver is either able to offload that or not. Up to the driver to > abstract this out. +1 If any of this "fake up a counter action" stuff is common to several  drivers, we could maybe have some library functions to help them with  it, but the tc<->driver API shouldn't change (since the change adds  no expressiveness). -ed