* Re: [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY
2026-01-23 11:06 [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY Vladimir Oltean
@ 2026-01-23 11:09 ` Christophe Leroy (CS GROUP)
2026-01-23 13:01 ` Venkat Rao Bagalkote
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-01-23 11:09 UTC (permalink / raw)
To: Vladimir Oltean, linux-phy, Vinod Koul, Neil Armstrong
Cc: netdev, Paolo Abeni, Bjørn Mork, linux-kernel,
Venkat Rao Bagalkote
Le 23/01/2026 à 12:06, Vladimir Oltean a écrit :
> Kconfig option CONFIG_PHY_COMMON_PROPS, which builds
> drivers/phy/phy-common-props.c, was intended to be selectable
> independently of CONFIG_GENERIC_PHY. Yet it lives in drivers/phy/, which
> is entered by the Makefile only if CONFIG_GENERIC_PHY is set.
>
> Allow the Makefile to enter one level deeper, but stop at drivers/phy/
> if CONFIG_GENERIC_PHY is unselected (i.e. do not enter vendor folders).
> The other stuff from drivers/phy/Makefile except for CONFIG_PHY_COMMON_PROPS,
> like CONFIG_PHY_NXP_PTN3222, all depends on CONFIG_GENERIC_PHY.
>
> Fixes: e7556b59ba65 ("phy: add phy_get_rx_polarity() and phy_get_tx_polarity()")
> Closes: https://lore.kernel.org/lkml/43ea0202-891d-4582-980b-5cb557b41114@linux.ibm.com/
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Debugged-by: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> drivers/Makefile | 2 +-
> drivers/phy/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index ccc05f1eae3e..53fbd2e0acdd 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -10,7 +10,7 @@ obj-y += cache/
> obj-y += irqchip/
> obj-y += bus/
>
> -obj-$(CONFIG_GENERIC_PHY) += phy/
> +obj-y += phy/
>
> # GPIO must come after pinctrl as gpios may need to mux pins etc
> obj-$(CONFIG_PINCTRL) += pinctrl/
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index 30b150d68de7..93715ea0d010 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -15,7 +15,7 @@ obj-$(CONFIG_PHY_SNPS_EUSB2) += phy-snps-eusb2.o
> obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o
> obj-$(CONFIG_PHY_AIROHA_PCIE) += phy-airoha-pcie.o
> obj-$(CONFIG_PHY_NXP_PTN3222) += phy-nxp-ptn3222.o
> -obj-y += allwinner/ \
> +obj-$(CONFIG_GENERIC_PHY) += allwinner/ \
> amlogic/ \
> broadcom/ \
> cadence/ \
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY
2026-01-23 11:06 [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY Vladimir Oltean
2026-01-23 11:09 ` Christophe Leroy (CS GROUP)
@ 2026-01-23 13:01 ` Venkat Rao Bagalkote
2026-02-03 9:56 ` Venkat Rao Bagalkote
2026-02-04 15:44 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Venkat Rao Bagalkote @ 2026-01-23 13:01 UTC (permalink / raw)
To: Vladimir Oltean, linux-phy, Vinod Koul, Neil Armstrong
Cc: netdev, Paolo Abeni, Bjørn Mork, linux-kernel,
Christophe Leroy (CS GROUP)
On 23/01/26 4:36 pm, Vladimir Oltean wrote:
> Kconfig option CONFIG_PHY_COMMON_PROPS, which builds
> drivers/phy/phy-common-props.c, was intended to be selectable
> independently of CONFIG_GENERIC_PHY. Yet it lives in drivers/phy/, which
> is entered by the Makefile only if CONFIG_GENERIC_PHY is set.
>
> Allow the Makefile to enter one level deeper, but stop at drivers/phy/
> if CONFIG_GENERIC_PHY is unselected (i.e. do not enter vendor folders).
> The other stuff from drivers/phy/Makefile except for CONFIG_PHY_COMMON_PROPS,
> like CONFIG_PHY_NXP_PTN3222, all depends on CONFIG_GENERIC_PHY.
>
> Fixes: e7556b59ba65 ("phy: add phy_get_rx_polarity() and phy_get_tx_polarity()")
> Closes: https://lore.kernel.org/lkml/43ea0202-891d-4582-980b-5cb557b41114@linux.ibm.com/
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Debugged-by: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---
> drivers/Makefile | 2 +-
> drivers/phy/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index ccc05f1eae3e..53fbd2e0acdd 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -10,7 +10,7 @@ obj-y += cache/
> obj-y += irqchip/
> obj-y += bus/
>
> -obj-$(CONFIG_GENERIC_PHY) += phy/
> +obj-y += phy/
>
> # GPIO must come after pinctrl as gpios may need to mux pins etc
> obj-$(CONFIG_PINCTRL) += pinctrl/
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index 30b150d68de7..93715ea0d010 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -15,7 +15,7 @@ obj-$(CONFIG_PHY_SNPS_EUSB2) += phy-snps-eusb2.o
> obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o
> obj-$(CONFIG_PHY_AIROHA_PCIE) += phy-airoha-pcie.o
> obj-$(CONFIG_PHY_NXP_PTN3222) += phy-nxp-ptn3222.o
> -obj-y += allwinner/ \
> +obj-$(CONFIG_GENERIC_PHY) += allwinner/ \
> amlogic/ \
> broadcom/ \
> cadence/ \
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY
2026-01-23 11:06 [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY Vladimir Oltean
2026-01-23 11:09 ` Christophe Leroy (CS GROUP)
2026-01-23 13:01 ` Venkat Rao Bagalkote
@ 2026-02-03 9:56 ` Venkat Rao Bagalkote
2026-02-03 12:25 ` Mark Brown
2026-02-04 15:44 ` Vinod Koul
3 siblings, 1 reply; 6+ messages in thread
From: Venkat Rao Bagalkote @ 2026-02-03 9:56 UTC (permalink / raw)
To: Vladimir Oltean, linux-phy, Vinod Koul, Neil Armstrong, broonie
Cc: netdev, Paolo Abeni, Bjørn Mork, linux-kernel,
Christophe Leroy (CS GROUP)
On 23/01/26 4:36 pm, Vladimir Oltean wrote:
> Kconfig option CONFIG_PHY_COMMON_PROPS, which builds
> drivers/phy/phy-common-props.c, was intended to be selectable
> independently of CONFIG_GENERIC_PHY. Yet it lives in drivers/phy/, which
> is entered by the Makefile only if CONFIG_GENERIC_PHY is set.
>
> Allow the Makefile to enter one level deeper, but stop at drivers/phy/
> if CONFIG_GENERIC_PHY is unselected (i.e. do not enter vendor folders).
> The other stuff from drivers/phy/Makefile except for CONFIG_PHY_COMMON_PROPS,
> like CONFIG_PHY_NXP_PTN3222, all depends on CONFIG_GENERIC_PHY.
>
> Fixes: e7556b59ba65 ("phy: add phy_get_rx_polarity() and phy_get_tx_polarity()")
> Closes: https://lore.kernel.org/lkml/43ea0202-891d-4582-980b-5cb557b41114@linux.ibm.com/
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Debugged-by: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> drivers/Makefile | 2 +-
> drivers/phy/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index ccc05f1eae3e..53fbd2e0acdd 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -10,7 +10,7 @@ obj-y += cache/
> obj-y += irqchip/
> obj-y += bus/
>
> -obj-$(CONFIG_GENERIC_PHY) += phy/
> +obj-y += phy/
>
> # GPIO must come after pinctrl as gpios may need to mux pins etc
> obj-$(CONFIG_PINCTRL) += pinctrl/
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index 30b150d68de7..93715ea0d010 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -15,7 +15,7 @@ obj-$(CONFIG_PHY_SNPS_EUSB2) += phy-snps-eusb2.o
> obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o
> obj-$(CONFIG_PHY_AIROHA_PCIE) += phy-airoha-pcie.o
> obj-$(CONFIG_PHY_NXP_PTN3222) += phy-nxp-ptn3222.o
> -obj-y += allwinner/ \
> +obj-$(CONFIG_GENERIC_PHY) += allwinner/ \
> amlogic/ \
> broadcom/ \
> cadence/ \
I still see linux-next build failures with next-20260202. Can we please
have this patch merged.
Mark, can you please pull this one.
Regards,
Venkat.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY
2026-02-03 9:56 ` Venkat Rao Bagalkote
@ 2026-02-03 12:25 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2026-02-03 12:25 UTC (permalink / raw)
To: Venkat Rao Bagalkote
Cc: Vladimir Oltean, linux-phy, Vinod Koul, Neil Armstrong, netdev,
Paolo Abeni, Bjørn Mork, linux-kernel,
Christophe Leroy (CS GROUP)
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Tue, Feb 03, 2026 at 03:26:47PM +0530, Venkat Rao Bagalkote wrote:
> I still see linux-next build failures with next-20260202. Can we please have
> this patch merged.
> Mark, can you please pull this one.
Patches aren't applied directly to linux-next, they are applied to the
various trees and then merged into -next.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY
2026-01-23 11:06 [PATCH phy] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY Vladimir Oltean
` (2 preceding siblings ...)
2026-02-03 9:56 ` Venkat Rao Bagalkote
@ 2026-02-04 15:44 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2026-02-04 15:44 UTC (permalink / raw)
To: linux-phy, Neil Armstrong, Vladimir Oltean
Cc: netdev, Paolo Abeni, Bjørn Mork, linux-kernel,
Venkat Rao Bagalkote, Christophe Leroy (CS GROUP)
On Fri, 23 Jan 2026 13:06:00 +0200, Vladimir Oltean wrote:
> Kconfig option CONFIG_PHY_COMMON_PROPS, which builds
> drivers/phy/phy-common-props.c, was intended to be selectable
> independently of CONFIG_GENERIC_PHY. Yet it lives in drivers/phy/, which
> is entered by the Makefile only if CONFIG_GENERIC_PHY is set.
>
> Allow the Makefile to enter one level deeper, but stop at drivers/phy/
> if CONFIG_GENERIC_PHY is unselected (i.e. do not enter vendor folders).
> The other stuff from drivers/phy/Makefile except for CONFIG_PHY_COMMON_PROPS,
> like CONFIG_PHY_NXP_PTN3222, all depends on CONFIG_GENERIC_PHY.
>
> [...]
Applied, thanks!
[1/1] phy: enter drivers/phy/Makefile even without CONFIG_GENERIC_PHY
commit: 3ddcd24b4d8454b2b9b2d013a0d61986ae8bbbe7
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread