From: Jacob Keller <jacob.e.keller@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, Petr Oros <poros@redhat.com>
Cc: <ivecera@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
Stanislav Fomichev <sdf@fomichev.me>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
<intel-wired-lan@lists.osuosl.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net] iavf: fix deadlock in reset handling
Date: Mon, 2 Feb 2026 17:00:08 -0800 [thread overview]
Message-ID: <b064ca33-1d94-4c7e-b0d0-78430d8cd0ac@intel.com> (raw)
In-Reply-To: <20260202155813.3f8fbc27@kernel.org>
On 2/2/2026 3:58 PM, Jakub Kicinski wrote:
> On Mon, 2 Feb 2026 09:48:20 +0100 Petr Oros wrote:
>> + netdev_unlock(netdev);
>> + ret = wait_event_interruptible_timeout(adapter->reset_waitqueue,
>> + !iavf_is_reset_in_progress(adapter),
>> + msecs_to_jiffies(5000));
>> + netdev_lock(netdev);
>
> Dropping locks taken by the core around the driver callback
> is obviously unacceptable. SMH.
Right. It seems like the correct fix is to either a) have reset take and
hold the netdev lock (now that its distinct from the global RTNL lock)
or b) refactor reset so that it can defer any of the netdev related
stuff somehow.
next prev parent reply other threads:[~2026-02-03 1:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 8:48 [PATCH net] iavf: fix deadlock in reset handling Petr Oros
2026-02-02 9:06 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-02-02 10:53 ` Jijie Shao
2026-02-02 13:30 ` Ivan Vecera
2026-02-02 23:58 ` Jakub Kicinski
2026-02-03 1:00 ` Jacob Keller [this message]
2026-02-03 8:44 ` [Intel-wired-lan] " Petr Oros
2026-02-03 10:19 ` Przemek Kitszel
2026-02-03 11:32 ` Petr Oros
2026-02-03 23:47 ` Jacob Keller
2026-02-04 6:12 ` Przemek Kitszel
2026-02-04 19:25 ` Jacob Keller
2026-02-05 12:24 ` Petr Oros
2026-02-05 23:37 ` Jacob Keller
2026-02-06 10:04 ` Petr Oros
2026-02-07 1:00 ` Jacob Keller
2026-02-07 3:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b064ca33-1d94-4c7e-b0d0-78430d8cd0ac@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox