From: Alexandre Ferrieux <alexandre.ferrieux@gmail.com>
To: Pedro Tammela <pctammela@mojatatu.com>,
Alexandre Ferrieux <alexandre.ferrieux@gmail.com>,
edumazet@google.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org
Subject: Re: [PATCH net] Fix u32's systematic failure to free IDR entries for hnodes.
Date: Mon, 4 Nov 2024 21:26:59 +0100 [thread overview]
Message-ID: <b08fb88f-129d-4e4a-8656-5f11334df300@gmail.com> (raw)
In-Reply-To: <433f99bd-5f68-4f4a-87c4-f8fd22bea95f@mojatatu.com>
On 04/11/2024 18:00, Pedro Tammela wrote:
>>
>> Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@orange.com>
>
> SoB does not match sender, probably missing 'From:' tag
Due to dumb administrativia at my organization, I am compelled to post from my
personal gmail accout in order for my posts to be acceptable on this mailing
list; while I'd like to keep my official address in commit logs. Is it possible ?
> Also, this seems to deserve a 'Fixes:' tag as well
This would be the initial commit:
^1da177e4c3f4 (Linus Torvalds 2005-04-16 15:20:36 -0700 19)
Is that what you mean ?
> 'static inline' is discouraged in .c files
Why ?
It could have been a local macro, but an inline has (a bit) better type
checking. And I didn't want to add it to a .h that is included by many other
unrelated components, as it makes no sense to them. So, what is the recommendation ?
next prev parent reply other threads:[~2024-11-04 20:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 10:26 [PATCH net] Fix u32's systematic failure to free IDR entries for hnodes Alexandre Ferrieux
2024-11-04 17:00 ` Pedro Tammela
2024-11-04 20:26 ` Alexandre Ferrieux [this message]
2024-11-04 21:33 ` Vadim Fedorenko
2024-11-04 21:51 ` Alexandre Ferrieux
2024-11-04 22:33 ` Florian Fainelli
2024-11-05 22:14 ` Alexandre Ferrieux
2024-11-05 23:42 ` Vadim Fedorenko
2024-11-06 10:15 ` Alexandre Ferrieux
2024-11-06 10:54 ` Vadim Fedorenko
2024-11-10 14:00 ` Simon Horman
2024-11-10 15:40 ` Alexandre Ferrieux
2024-11-11 20:07 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2024-11-01 18:43 Alexandre Ferrieux
2024-11-04 10:11 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b08fb88f-129d-4e4a-8656-5f11334df300@gmail.com \
--to=alexandre.ferrieux@gmail.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).