From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>, davem@davemloft.net
Cc: jiri@resnulli.us, roopa@cumulusnetworks.com,
christian.brauner@ubuntu.com, netdev@vger.kernel.org,
oss-drivers@netronome.com
Subject: Re: [PATCH net-next 1/2] rtnetlink: remove a level of indentation in rtnl_newlink()
Date: Wed, 28 Nov 2018 10:53:09 -0700 [thread overview]
Message-ID: <b09d3fe1-c372-f8e2-2dc8-3504cb811b5d@gmail.com> (raw)
In-Reply-To: <20181128063231.12907-2-jakub.kicinski@netronome.com>
On 11/27/18 11:32 PM, Jakub Kicinski wrote:
> rtnl_newlink() used to create VLAs based on link kind. Since
> commit ccf8dbcd062a ("rtnetlink: Remove VLA usage") statically
> sized array is created on the stack, so there is no more use
> for a separate code block that used to be the VLA's live range.
>
> While at it christmas tree the variables. Note that there is
> a goto-based retry so to be on the safe side the variables can
> no longer be initialized in place. It doesn't seem to matter,
> logically, but why make the code harder to read..
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> net/core/rtnetlink.c | 313 +++++++++++++++++++++----------------------
> 1 file changed, 154 insertions(+), 159 deletions(-)
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-11-29 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 6:32 [PATCH net-next 0/2] rtnetlink: avoid a warning in rtnl_newlink() Jakub Kicinski
2018-11-28 6:32 ` [PATCH net-next 1/2] rtnetlink: remove a level of indentation " Jakub Kicinski
2018-11-28 17:53 ` David Ahern [this message]
2018-11-28 6:32 ` [PATCH net-next 2/2] rtnetlink: avoid frame size warning " Jakub Kicinski
2018-11-28 17:53 ` David Ahern
2018-11-28 17:52 ` [PATCH net-next 0/2] rtnetlink: avoid a " David Ahern
2018-11-30 21:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b09d3fe1-c372-f8e2-2dc8-3504cb811b5d@gmail.com \
--to=dsahern@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).