From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 1/2] rtnetlink: remove a level of indentation in rtnl_newlink() Date: Wed, 28 Nov 2018 10:53:09 -0700 Message-ID: References: <20181128063231.12907-1-jakub.kicinski@netronome.com> <20181128063231.12907-2-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: jiri@resnulli.us, roopa@cumulusnetworks.com, christian.brauner@ubuntu.com, netdev@vger.kernel.org, oss-drivers@netronome.com To: Jakub Kicinski , davem@davemloft.net Return-path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:37712 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727867AbeK2Ezi (ORCPT ); Wed, 28 Nov 2018 23:55:38 -0500 Received: by mail-pl1-f196.google.com with SMTP id b5so17757528plr.4 for ; Wed, 28 Nov 2018 09:53:12 -0800 (PST) In-Reply-To: <20181128063231.12907-2-jakub.kicinski@netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/27/18 11:32 PM, Jakub Kicinski wrote: > rtnl_newlink() used to create VLAs based on link kind. Since > commit ccf8dbcd062a ("rtnetlink: Remove VLA usage") statically > sized array is created on the stack, so there is no more use > for a separate code block that used to be the VLA's live range. > > While at it christmas tree the variables. Note that there is > a goto-based retry so to be on the safe side the variables can > no longer be initialized in place. It doesn't seem to matter, > logically, but why make the code harder to read.. > > Signed-off-by: Jakub Kicinski > --- > net/core/rtnetlink.c | 313 +++++++++++++++++++++---------------------- > 1 file changed, 154 insertions(+), 159 deletions(-) Reviewed-by: David Ahern