From mboxrd@z Thu Jan 1 00:00:00 1970 From: "santosh.shilimkar@oracle.com" Subject: Re: [PATCH net-next 4/5] rds: invoke socket sg filter attached to rds socket Date: Tue, 11 Sep 2018 14:06:23 -0700 Message-ID: References: <1536694684-3200-1-git-send-email-tushar.n.dave@oracle.com> <1536694684-3200-5-git-send-email-tushar.n.dave@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Tushar Dave , ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, jakub.kicinski@netronome.com, quentin.monnet@netronome.com, jiong.wang@netronome.com, sandipan@linux.vnet.ibm.com, john.fastabend@gmail.com, kafai@fb.com, rdna@fb.com, yhs@fb.com, netdev@vger.kernel.org, rds-devel@oss.oracle.com, sowmini.varadhan@oracle.com Return-path: Received: from userp2130.oracle.com ([156.151.31.86]:47804 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726870AbeILCIY (ORCPT ); Tue, 11 Sep 2018 22:08:24 -0400 In-Reply-To: <1536694684-3200-5-git-send-email-tushar.n.dave@oracle.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/11/18 12:38 PM, Tushar Dave wrote: > RDS module sits on top of TCP (rds_tcp) and IB (rds_rdma), so messages > arrive in form of skb (over TCP) and scatterlist (over IB/RDMA). > However, because socket filter only deal with skb (e.g. struct skb as > bpf context) we can only use socket filter for rds_tcp and not for > rds_rdma. > > Considering one filtering solution for RDS, it seems that the common > denominator between sk_buff and scatterlist is scatterlist. Therefore, > this patch converts skb to sgvec and invoke sg_filter_run for > rds_tcp and simply invoke sg_filter_run for IB/rds_rdma. > > Signed-off-by: Tushar Dave > Reviewed-by: Sowmini Varadhan > --- I remember acking the earlier version. Here it is again.. Acked-by: Santosh Shilimkar