From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.57 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793772367; b=Rke/YGVOZKYNihvaJppbIhxxTYKv7bdBmAv2AUbyzrWJVFwJTxxPm1ibzzJ6e0ELt/hv b7O2DkFnqKa9nlwXd+f6DklFWcoHdt76oaDfWv4f8qgtv5QWu0NH90rCOeY+waX70D2XS 4oLlpLLtbosL2/IOVTFj6O6o1HOw2vkcSSukttarAG2EhNaHJVeOZFaWWmjGnociKDW3l tJFAfIgBfmvreVwXgTzZSiqt+0rz7sExAagp5zrPpyJMxv5zm/v1+1onJiBR3dovdocq/ 01BhDuFI9pboLQtq7wyGEd30eWlq2X/CDs7jNrH/3Kr6TsXnThJC4NvOYgrJysY4PNA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793772367; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=AYliQvvoP9t2xBU+MfGX2zhe1ZgquUqopej93F/CQ4Q=; b=K937gaODBnSzjn90f7nG1Aj5QSK/CiWXYzSJhVvoWay8SEGJE8chbsw81ZFyUUKI4uPe hZE5nYDiwgLoPaplLd4M6gpwRFxURzDly6j/5pRwY3rlEHsi/u/HkkqjdMOPWW3TSXOo/ dJGHUw0DAu4Be+WlxRG7KicdsRK1ccg3/T55tx6d/5KZJnwxeW7Zw+U/lGd902j5whQ7G Af9m9qx+9OeIcx96EChe81ZuksYOvPvZ8pgAUhtQWwYTG9WdA06IdgCK4KkAMEX5D1PYT 5FRKeYz3sQ60wOvktkKePX7I6H55DCsRxw9u66rJfbakCZmSxiJihZn4BmzrMRWylFQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; arc=none smtp.remote-ip=91.218.175.57 Received: from mta0.migadu.com (out-57.mta0.migadu.com [91.218.175.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B620F606A31B for ; Wed, 4 Nov 2026 06:05:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B620F606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=AYliQvvoP9t2xBU+MfGX2zhe1ZgquUqopej93F/CQ4Q=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793772354; v=1; x=1794377154; b=tG0OTtk0f8ZcYcb+ozibhuTIE8MGWeWV43lqRPVcurrDR1RPMyw+7dPAjB2cpk+w+/sPh3WS H+cFhr11CppQ5DHLndMniEipQaOax5wvG23fFvUUerj5ERLXqGc+CrFbyriCPuNDOwogw40Z5mT Yx1TxtPR9oycfNTCLEH74xAA= X-Envelope-To: netdev@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id ba0b2edfcf9ab841; Wed, 04 Nov 2026 06:05:54 +0000 X-Mizu-Trace-ID: ba0b2edfcf9ab841 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 4 Nov 2026 14:05:38 +0800 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 5/7] ipv4: convert do_ip_getsockopt() to sockopt_t To: Breno Leitao , David Ahern , Ido Schimmel , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , John Fastabend , Stanislav Fomichev , Shuah Khan , Eric Dumazet Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, david.laight.linux@gmail.com, kernel-team@meta.com References: <20261103-sockopt_expand_out_v2-v4-0-2d36da923578@debian.org> <20261103-sockopt_expand_out_v2-v4-5-2d36da923578@debian.org> From: Jiayuan Chen In-Reply-To: <20261103-sockopt_expand_out_v2-v4-5-2d36da923578@debian.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/3/26 7:01 PM, Breno Leitao wrote: > Convert the SOL_IP switch and ip_mroute_getsockopt() to sockopt_t, its > last leaf on a sockptr_t pair. The IP_MSFILTER and MCAST_MSFILTER > bridges go away. > > ip_getsockopt() builds the sockopt_t with sockopt_init_user() and > writes optlen back unconditionally, because IP_OPTIONS and others > report a length and can then fail. ip_mc_msfget() therefore stores its > length only after its last copy, so a copy failure can't report a > changed one. > > The write-back also happens before the netfilter fallback, so an > unwritable optlen turns any error into -EFAULT and skips the fallback. > Likewise optlen is now read before the level check and the MRT_* > dispatch, so an unreadable or negative one wins over -EOPNOTSUPP. > > IP_OPTIONS with no options set and IP_PKTOPTIONS used to return the > result of copy_to_sockptr(), the number of bytes not copied, so an > unwritable optlen made getsockopt() return 4. They now return -EFAULT. > > sol_ip_sockopt() builds the sockopt_t with sockptr_to_sockopt() and > stores optlen back as well. This extra code will go away when we > convert sol_ip_sockopt() to talk sockopt as well, but for now we are > converting the leaves. > > Acked-by: Stanislav Fomichev > Acked-by: Ido Schimmel > Signed-off-by: Breno Leitao Reviewed-by: Jiayuan Chen