From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Samudrala, Sridhar" Subject: Re: [PATCH 2/2 net-next] net_failover: fix error code in net_failover_create() Date: Thu, 31 May 2018 10:26:41 -0700 Message-ID: References: <20180531120425.tqwhhfxqawjuvtws@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter , "David S. Miller" Return-path: Received: from mga01.intel.com ([192.55.52.88]:16875 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755819AbeEaR04 (ORCPT ); Thu, 31 May 2018 13:26:56 -0400 In-Reply-To: <20180531120425.tqwhhfxqawjuvtws@kili.mountain> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/31/2018 5:04 AM, Dan Carpenter wrote: > We forgot to set the error code on this path. This function is supposed > to return error pointers, so with this bug it accidentally returns NULL > and the caller doesn't check for that. > > Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") > Signed-off-by: Dan Carpenter Acked-by: Sridhar Samudrala > > diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c > index ef50158e90a9..881f3fa13e6b 100644 > --- a/drivers/net/net_failover.c > +++ b/drivers/net/net_failover.c > @@ -761,8 +761,10 @@ struct failover *net_failover_create(struct net_device *standby_dev) > netif_carrier_off(failover_dev); > > failover = failover_register(failover_dev, &net_failover_ops); > - if (IS_ERR(failover)) > + if (IS_ERR(failover)) { > + err = PTR_ERR(failover); > goto err_failover_register; > + } > > return failover; >