From: Paolo Abeni <pabeni@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Eyal Birger <eyal.birger@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v3 1/5] tc/act: user space can't use TC_ACT_REDIRECT directly
Date: Wed, 25 Jul 2018 18:29:02 +0200 [thread overview]
Message-ID: <b12cbc5aaf2afffc5f63b77038e4792c08bf8d85.camel@redhat.com> (raw)
In-Reply-To: <f65cbf3d99529ff8b820788ebe09466560d19c14.camel@redhat.com>
On Wed, 2018-07-25 at 17:48 +0200, Paolo Abeni wrote:
> On Wed, 2018-07-25 at 15:03 +0200, Jiri Pirko wrote:
> > Well it was obviously wrong to expose TC_ACT_REDIRECT to uapi and it
> > really has no meaning for anyone to use it throughout its whole history.
> > I would vote for "fail", yet I admit that I am usually alone in opinion
> > about similar uapi changes :)
>
> Since even Jamal suggested the same, unless someone else voice some
> opposition soon, in v4 I'll opt for rejecting actions using
> TC_ACT_REDIRECT.
Thinking again about it, I'm going to drop this patch from this series.
Since v2 is not strictly needed anymore and actually quite unrelated.
Thanks and sorry for the reiterated noise ;)
Paolo
next prev parent reply other threads:[~2018-07-25 17:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 20:06 [PATCH net-next v3 0/5] TC: refactor act_mirred packets re-injection Paolo Abeni
2018-07-24 20:06 ` [PATCH net-next v3 1/5] tc/act: user space can't use TC_ACT_REDIRECT directly Paolo Abeni
2018-07-25 11:55 ` Jamal Hadi Salim
2018-07-25 11:56 ` Jiri Pirko
2018-07-25 12:54 ` Paolo Abeni
2018-07-25 13:03 ` Jiri Pirko
2018-07-25 15:48 ` Paolo Abeni
2018-07-25 16:29 ` Paolo Abeni [this message]
2018-07-25 16:29 ` Daniel Borkmann
2018-07-26 7:43 ` Jiri Pirko
2018-07-27 2:48 ` Daniel Borkmann
2018-07-24 20:06 ` [PATCH net-next v3 2/5] net/sched: user-space can't set unknown tcfa_action values Paolo Abeni
2018-07-25 12:26 ` Jiri Pirko
2018-07-24 20:06 ` [PATCH net-next v3 3/5] tc/act: remove unneeded RCU lock in action callback Paolo Abeni
2018-07-25 11:59 ` Jamal Hadi Salim
2018-07-25 18:24 ` Marcelo Ricardo Leitner
2018-07-25 12:32 ` Jiri Pirko
2018-07-24 20:06 ` [PATCH net-next v3 4/5] net/tc: introduce TC_ACT_REINJECT Paolo Abeni
2018-07-24 20:38 ` Cong Wang
2018-07-24 20:50 ` Cong Wang
2018-07-25 8:29 ` Paolo Abeni
2018-07-25 12:27 ` Jamal Hadi Salim
2018-07-25 14:24 ` Paolo Abeni
2018-07-25 15:26 ` Jamal Hadi Salim
2018-07-25 16:48 ` Cong Wang
2018-07-25 17:09 ` Marcelo Ricardo Leitner
2018-07-26 12:52 ` Jamal Hadi Salim
2018-07-26 23:25 ` Cong Wang
2018-07-25 12:16 ` Jamal Hadi Salim
2018-07-25 12:59 ` Jiri Pirko
2018-07-25 13:55 ` Paolo Abeni
2018-07-25 12:57 ` Jiri Pirko
2018-07-24 20:06 ` [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible Paolo Abeni
2018-07-24 21:15 ` Cong Wang
2018-07-25 10:14 ` Paolo Abeni
2018-07-25 13:30 ` Jiri Pirko
2018-07-25 11:50 ` Jamal Hadi Salim
2018-07-25 13:52 ` Jiri Pirko
2018-07-25 14:04 ` Paolo Abeni
2018-07-25 14:30 ` Jiri Pirko
2018-07-25 11:53 ` [PATCH net-next v3 0/5] TC: refactor act_mirred packets re-injection Jiri Pirko
2018-07-25 12:07 ` Paolo Abeni
2018-07-25 12:17 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b12cbc5aaf2afffc5f63b77038e4792c08bf8d85.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eyal.birger@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).