From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f42.google.com ([209.85.160.42]:38325 "EHLO
        mail-pl0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752683AbeCPSGK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 16 Mar 2018 14:06:10 -0400
Received: by mail-pl0-f42.google.com with SMTP id m22-v6so6377351pls.5
        for <netdev@vger.kernel.org>; Fri, 16 Mar 2018 11:06:10 -0700 (PDT)
Subject: Re: [PATCH net-next 3/9] selftests: pmtu: Introduce support for
 multiple tests
To: Stefano Brivio <sbrivio@redhat.com>,
        "David S . Miller" <davem@davemloft.net>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        netdev@vger.kernel.org
References: <cover.1521129192.git.sbrivio@redhat.com>
 <2870b8f3ab9ce40d3dbcfc1f308aba580f59197f.1521129192.git.sbrivio@redhat.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <b12fdfeb-87b8-ef88-11c3-7a13a352fd00@gmail.com>
Date: Fri, 16 Mar 2018 11:06:07 -0700
MIME-Version: 1.0
In-Reply-To: <2870b8f3ab9ce40d3dbcfc1f308aba580f59197f.1521129192.git.sbrivio@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 3/15/18 9:18 AM, Stefano Brivio wrote:
>  trap cleanup EXIT
>  
> -test_pmtu_vti6_exception
> +exitcode=0
> +for name in ${tests}; do
> +	echo "${name}: START"
> +	eval test_${name}
> +	ret=$?
> +	cleanup
> +
> +	if [ $ret -eq 0 ]; then echo "${name}: FAIL"; exitcode=1

ret = 0 == failure is counterintuitive for Linux.

> +	elif [ $ret -eq 1 ]; then echo "${name}: PASS"
> +	elif [ $ret -eq 2 ]; then echo "${name}: SKIP"

I use printf in other scripts so that the pass/fail verdict lineup. e.g.,
printf "        %-60s  [PASS]\n" "${name}"


> +	fi
> +done
>  
> -exit 0
> +exit ${exitcode}
>