From: yajun.deng@linux.dev
To: "Eric Dumazet" <eric.dumazet@gmail.com>,
davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] neigh: introduce __neigh_confirm() for __ipv{4, 6}_confirm_neigh
Date: Thu, 18 Nov 2021 02:24:30 +0000 [thread overview]
Message-ID: <b152a438cb03908f390c27e98c2c5ca0@linux.dev> (raw)
In-Reply-To: <8696b472-efee-7801-8480-dd0a5ebf173b@gmail.com>
November 18, 2021 1:36 AM, "Eric Dumazet" <eric.dumazet@gmail.com> wrote:
> On 11/17/21 4:02 AM, Yajun Deng wrote:
>
>> Those __ipv4_confirm_neigh(), __ipv6_confirm_neigh() and __ipv6_confirm_neigh_stub()
>> functions have similar code. introduce __neigh_confirm() for it.
>
> At first glance, this might add an indirect call ?
Yes, But this need keep __ipv4_confirm_neigh() the same parameters as __ipv6_confirm_neigh().
next prev parent reply other threads:[~2021-11-18 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 12:02 [PATCH net-next] neigh: introduce __neigh_confirm() for __ipv{4, 6}_confirm_neigh Yajun Deng
2021-11-17 17:36 ` Eric Dumazet
2021-11-18 2:24 ` yajun.deng [this message]
2021-11-17 19:34 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b152a438cb03908f390c27e98c2c5ca0@linux.dev \
--to=yajun.deng@linux.dev \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).