From: subashab@codeaurora.org
To: David Ahern <dsahern@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org,
dsahern@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipv6: addrconf: Add accept_ra_prefix_route.
Date: Thu, 11 Mar 2021 19:22:17 -0700 [thread overview]
Message-ID: <b15ef2166740ad67c7685aaed27b5534@codeaurora.org> (raw)
In-Reply-To: <cbcfa6d3c4fa057051bbee6851e9d4e7@codeaurora.org>
On 2021-03-10 14:33, subashab@codeaurora.org wrote:
> On 2021-03-10 12:28, David Ahern wrote:
>> On 3/10/21 11:49 AM, Subash Abhinov Kasiviswanathan wrote:
>>> Added new procfs flag to toggle the automatic addition of prefix
>>> routes on a per device basis. The new flag is accept_ra_prefix_route.
>>>
>>> A value of 0 for the flag maybe used in some forwarding scenarios
>>> when a userspace daemon is managing the routing.
>>> Manual deletion of the kernel installed route was not sufficient as
>>> kernel was adding back the route.
>>>
>>> Defaults to 1 as to not break existing behavior.
>>>
>>> Signed-off-by: Subash Abhinov Kasiviswanathan
>>> <subashab@codeaurora.org>
>>> ---
>>> Documentation/networking/ip-sysctl.rst | 10 ++++++++++
>>> include/linux/ipv6.h | 1 +
>>> include/uapi/linux/ipv6.h | 1 +
>>> net/ipv6/addrconf.c | 16 +++++++++++++---
>>> 4 files changed, 25 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/networking/ip-sysctl.rst
>>> b/Documentation/networking/ip-sysctl.rst
>>> index c7952ac..9f0d92d 100644
>>> --- a/Documentation/networking/ip-sysctl.rst
>>> +++ b/Documentation/networking/ip-sysctl.rst
>>> @@ -2022,6 +2022,16 @@ accept_ra_mtu - BOOLEAN
>>> - enabled if accept_ra is enabled.
>>> - disabled if accept_ra is disabled.
>>>
>>> +accept_ra_prefix_route - BOOLEAN
>>> + Apply the prefix route based on the RA. If disabled, kernel
>>> + does not install the route. This can be used if a userspace
>>> + daemon is managing the routing.
>>> +
>>> + Functional default:
>>> +
>>> + - enabled if accept_ra_prefix_route is enabled
>>> + - disabled if accept_ra_prefix_route is disabled
>>> +
>>> accept_redirects - BOOLEAN
>>> Accept Redirects.
>>>
>>
>> this seems to duplicate accept_ra_pinfo
>
> Thanks David. We will try out that entry instead and check.
We are seeing that the interface itself doesn't get the address assigned
via RA when setting accept_ra_pinfo = 0.
We would like to have the interface address assigned via SLAAC
here while the route management would be handled via the userspace
daemon.
In that case, we do not want the kernel installed route to be present
(behavior controlled via this proc entry).
next prev parent reply other threads:[~2021-03-12 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 18:49 [PATCH net-next] net: ipv6: addrconf: Add accept_ra_prefix_route Subash Abhinov Kasiviswanathan
2021-03-10 19:28 ` David Ahern
2021-03-10 21:33 ` subashab
2021-03-12 2:22 ` subashab [this message]
2021-03-12 16:41 ` David Ahern
2021-03-12 23:30 ` subashab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b15ef2166740ad67c7685aaed27b5534@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).